Uh oh!
There was an error while loading. Please reload this page.
refactor(download): use DownloadCallBack in download_with_backend() - #3795
Merged
Conversation
djc
approved these changes
Apr 27, 2024
djc
left a comment
Contributor
There was a problem hiding this comment.
Seems okay, honestly I don't think type aliases like this are useful, so I'd prefer to just get rid of it.
MemberAuthor
@djc This type was introduced to address clippy::type_complexity in #3133. I don't think it's worth it to override the lint level for this type 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trivial patch cherry-picked from #3788.