Uh oh!
There was an error while loading. Please reload this page.
feat(download-backend)!: make reqwest/rustls the new default - #3798
Merged
Conversation
djc
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3790.
This PR has also fixed the weird business logic where
RUSTUP_USE_CURL=0actually instructs Rustup to use the curl backend, which might surprise many people including myself and @fh-igd-mueller-roemer from #3791 (comment).A more ideal solution OTOH would be borrowing from my previous work on clap-rs/clap#2664 (Aha, dots connected!), however I'm not sure about its interactions with our current
process().var_os(). Maybe only the parsing part should be copied over.