Skip to content

Replace remaining winapi usage with windows-sys - #3802

Merged
rami3l merged 1 commit into
rust-lang:masterfrom
kennykerr:windows-sys
May 6, 2024
Merged

Replace remaining winapi usage with windows-sys#3802
rami3l merged 1 commit into
rust-lang:masterfrom
kennykerr:windows-sys

Conversation

@kennykerr

Copy link
Copy Markdown
Contributor

I noticed that the rustup project already started adopting the windows-sys crate. This update merely replaces the remaining direct dependencies on the older winapi crate with windows-sys.

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup! I'll merge this PR shortly after the v1.27.1 release.

@rami3l

rami3l commented May 2, 2024

Copy link
Copy Markdown
Member

@kennykerr One small thing: since we're using rebase merge, would you mind rewording the single commit in this patch? Reusing the PR title would be just fine :)

djc
djc approved these changes May 2, 2024
@kennykerr

Copy link
Copy Markdown
ContributorAuthor

@rami3l I've renamed the commit.

@rami3lrami3l mentioned this pull request May 6, 2024
1 task
@rami3l
rami3l added this pull request to the merge queue May 6, 2024
@rami3lrami3l added this to the 1.28.0 milestone May 6, 2024
Merged via the queue into rust-lang:master with commit db55a2cMay 6, 2024
@rami3lrami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kennykerr@rami3l@djc