Skip to content

fix(filesource): make some constructs only available via the test feature - #3811

Merged
djc merged 1 commit into
masterfrom
fix/dead-code
May 7, 2024
Merged

fix(filesource): make some constructs only available via the test feature#3811
djc merged 1 commit into
masterfrom
fix/dead-code

Conversation

@rami3l

@rami3lrami3l commented May 7, 2024

Copy link
Copy Markdown
Member

Cherry-picked from #3803.

This PR has fixed the following warnings in https://github.com/rust-lang/rustup/actions/runs/8978258543/job/24658381207:

 warning:struct `TestStdinLock` is never constructed
--> src/currentprocess/filesource.rs:47:8
|
47 | struct TestStdinLock<'a> {
| ^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning:type alias `TestStdinInner` is never used
--> src/currentprocess/filesource.rs:68:17
|
68 | pub(crate)typeTestStdinInner = Arc<Mutex<Cursor<String>>>;
| ^^^^^^^^^^^^^^
warning: struct `TestStdin` is never constructed
--> src/currentprocess/filesource.rs:70:8
|
70 | struct TestStdin(TestStdinInner);
| ^^^^^^^^^
warning:struct `TestWriterLock` is never constructed
--> src/currentprocess/filesource.rs:182:19
|
182 | pub(super)structTestWriterLock<'a> {
| ^^^^^^^^^^^^^^
warning: `rustup` (lib) generated 4 warnings

@rami3lrami3l added this to the 1.28.0 milestone May 7, 2024
@rami3l
rami3l requested a review from djcMay 7, 2024 03:22
djc
djc approved these changes May 7, 2024
Comment threadsrc/currentprocess/filesource.rs
@rami3l
rami3l requested a review from djcMay 7, 2024 10:55
@djc
djc added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit adfcf0fMay 7, 2024
@djc
djc deleted the fix/dead-code branch May 7, 2024 11:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rami3l@djc