Skip to content

Refactoring around use of Process - #3860

Merged
djc merged 17 commits into
masterfrom
cfg-current-dir
Jun 5, 2024
Merged

Refactoring around use of Process#3860
djc merged 17 commits into
masterfrom
cfg-current-dir

Conversation

@djc

@djcdjc commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Various changes which I've made several times now that try to untangle the codebase mostly by inlining short and/or single-use methods. Preparation for moving more stuff out of the ambient Process global.

@djc
djc requested a review from rami3lJune 5, 2024 05:23
@djc
djcforce-pushed the cfg-current-dir branch from fec5307 to 1963396CompareJune 5, 2024 05:33
@djc
djcforce-pushed the cfg-current-dir branch from 1963396 to b8fa753CompareJune 5, 2024 08:42
@djcdjc changed the title Get rid of Process::current_dir()Refactoring around use of ProcessJun 5, 2024
Comment threadsrc/cli/proxy_mode.rs Outdated
@djc
djcforce-pushed the cfg-current-dir branch from ae64d51 to 0163f2eCompareJune 5, 2024 09:27

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@djc
djc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit ee1fa08Jun 5, 2024
@djc
djc deleted the cfg-current-dir branch June 5, 2024 10:53
@rami3lrami3l added this to the 1.28.0 milestone Jun 9, 2024
@rami3lrami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@djc@rami3l