Uh oh!
There was an error while loading. Please reload this page.
Conversation
c1838e7 to
686defaCompare| }) | ||
| } | ||
| _ => Err(RustupError::UnknownMetadataVersion(current_version).into()), | ||
| MetadataVersion::V12 => { |
There was a problem hiding this comment.
To me it's clear that the happy path in the original code is for MetadataVersion::default(), but now it's for MetadataVersion::V12. I know at the moment being it's all the same, but the meaning being conveyed seems to be a bit different, and that might cause problems when the default value changes 🤔
There was a problem hiding this comment.
I've reverted the logic to something closer to what was originally there.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rami3l
left a comment
There was a problem hiding this comment.
Nice improvements overall! Somehow I thought we were using serde for such things already 🤣
This saves a bunch of code (-190 lines) and is generally more idiomatic. It also saves about 8% of latency on proxy invocations, after (both best of 3 runs):
before: