Skip to content

Fix misleading "uninstalled toolchain" notification - #3869

Merged
rami3l merged 1 commit into
rust-lang:masterfrom
scimas:misleading-toolchain-uninstall
Jun 12, 2024
Merged

Fix misleading "uninstalled toolchain" notification#3869
rami3l merged 1 commit into
rust-lang:masterfrom
scimas:misleading-toolchain-uninstall

Conversation

@scimas

Copy link
Copy Markdown
Contributor

Added a check to see if any filesystem modification was done. Fixes#3861.

Added a check to see if any filesystem modification was done.
djc
djc approved these changes Jun 12, 2024

@djcdjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

@rami3l
rami3l added this pull request to the merge queue Jun 12, 2024
Merged via the queue into rust-lang:master with commit d05498eJun 12, 2024
@scimas
scimas deleted the misleading-toolchain-uninstall branch June 12, 2024 14:14
@rami3lrami3l added this to the 1.28.0 milestone Jun 16, 2024
@rami3lrami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup toolchain uninstall <toolchain> reports toolchain has been uninstalled without doing anything

3 participants

@scimas@djc@rami3l