Process cleanup

[djc]

This is from last night. I think the custom test macros are unnecessary now, please review!

[rami3l]

Wow that's soooo impressive, friend!

Rustup is finally an "ordinary" tokio app now thanks to your work! Hooray 🎉

[djc]

Rustup is finally an "ordinary" tokio app now thanks to your work! Hooray 🎉

Our work, couldn't have done it without you!

[rami3l]

@djc Let's don't forget there's one remaining concern from #3847 (comment): there are places where the original code was using #[::tokio::test(flavor = "multi_thread", worker_threads = 1)] (you just deleted these lines in this PR), while worker_threads = 2 was used in with_runtime() instead:

rustup/src/test/mock/clitools.rs

Lines 729 to 738 in 0aa7a2a

	letmut builder = Builder::new_multi_thread();
	builder
	.enable_all()
	.worker_threads(2)
	.max_blocking_threads(2);
	let process_res = currentprocess::with_runtime(
	tp.clone().into(),
	builder,
	rustup_mode::main(tp.cwd.clone()),
	);

I'm not quite sure about the exact intention of those configurations, but it's better to be watchful I think.