Skip to content

refactor(dist): hoist dist::dist into dist - #3882

Merged
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:refactor/no-dist-dist
Jun 17, 2024
Merged

refactor(dist): hoist dist::dist into dist#3882
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:refactor/no-dist-dist

Conversation

@rami3l

@rami3lrami3l commented Jun 17, 2024

Copy link
Copy Markdown
Member

This is a natural step in the spirit of #3880.

Concerns

@rami3l
rami3l requested a review from djcJune 17, 2024 04:17
@rami3l
rami3lforce-pushed the refactor/no-dist-dist branch from 700b505 to e6ca90cCompareJune 17, 2024 04:20
djc
djc approved these changes Jun 17, 2024
Comment threadsrc/dist/mod.rs
@djc

djc commented Jun 17, 2024

Copy link
Copy Markdown
Contributor
  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)

I still find this still imposes non-trivial cognitive overhead because it means each module appears twice in the directory tree, and I have to decide which one I need to open.

@rami3l

Copy link
Copy Markdown
MemberAuthor

This is a natural step in the spirit of #3880.

Concerns

  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)
  • It's time to decide between foo.rs and foo/mod.rs. (I'm slightly inclined towards foo.rs, cc @rbtcollins.)

I still find this still imposes non-trivial cognitive overhead because it means each module appears twice in the directory tree, and I have to decide which one I need to open.

@djc Let's continue the discussion at #3883 since it looks not very appropriate to comment on a soon-to-be closed PR :P

@rami3l
rami3l requested a review from djcJune 17, 2024 06:36
@rami3lrami3l added this to the 1.28.0 milestone Jun 17, 2024
djc
djc approved these changes Jun 17, 2024
@rami3l
rami3l added this pull request to the merge queue Jun 17, 2024
Merged via the queue into rust-lang:master with commit c1768a7Jun 17, 2024
@rami3l
rami3l deleted the refactor/no-dist-dist branch June 17, 2024 07:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rami3l@djc