Uh oh!
There was an error while loading. Please reload this page.
Port tests to CliTestContext - #3893
Merged
Merged
Conversation
rami3l
reviewed
Jun 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
rami3lforce-pushed
the
test-contexts
branch
2 times, most recently
from
June 20, 2024 07:30
bd2ba9b to
403ef2dComparedjcforce-pushed
the
test-contexts
branch
2 times, most recently
from
June 22, 2024 12:51
7504c1e to
cff0cbbComparedjc
marked this pull request as ready for review
June 22, 2024 12:58
rami3l
reviewed
Jun 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
rami3l
approved these changes
Jun 22, 2024
rami3l
left a comment
Member
There was a problem hiding this comment.
Thanks again for the tremendous amount of work (~14 000 diffLoC)! Wouldn't be possible without you!
djc
enabled auto-merge
June 22, 2024 16:36
djc
commented
Jun 22, 2024
ContributorAuthor
Too bad this is like +1000 lines... all from adding async in the CLI tests. Oh well... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.