Skip to content

Add loongarch64-unknown-linux-musl support - #3921

Merged
rami3l merged 2 commits into
rust-lang:masterfrom
heiher:loongarch64-linux-musl
Jul 5, 2024
Merged

Add loongarch64-unknown-linux-musl support#3921
rami3l merged 2 commits into
rust-lang:masterfrom
heiher:loongarch64-linux-musl

Conversation

@heiher

@heiherheiher commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

skip-stable because we're not going to release this for now

rami3l
rami3l reviewed Jul 4, 2024
View reviewed changes
Comment threadci/actions-templates/README.md Outdated
rami3l
rami3l reviewed Jul 4, 2024
View reviewed changes
Comment threadci/actions-templates/linux-builds-template.yaml
- x86_64-linux-android # skip-pr skip-master
- riscv64gc-unknown-linux-gnu # skip-pr skip-master
- loongarch64-unknown-linux-gnu # skip-pr skip-master
- loongarch64-unknown-linux-musl # skip-pr skip-master skip-stable

@rami3lrami3lJul 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm so you're saying that the CI should completely ignore this target as for now, if I'm not mistaken?

@heiherheiherJul 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If I'm not mistaken, rustup is currently only built with stable rustc. The first stable version of loongarch64-linux-musl will be 1.81, when skip-stable will be removed. Thanks

@rami3lrami3lJul 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher I see. Thanks for the explanation!

@rami3lrami3lOct 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher Are we ready for releasing this on stable now?

This should be the right time if possible, since we're releasing v1.28.0 beta very soon:

@rami3lrami3lDec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher (a gentle ping...)

@heiherheiherDec 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the previous notification. I’ll enable the stable build for this target soon. Thanks for your mention.

@rami3lrami3lDec 4, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher Thanks for your approval! I'll place this change directly in #4105 for the sake of convenience :)

@rami3lrami3l added this to the 1.28.0 milestone Jul 4, 2024
@rami3l
rami3l requested a review from djcJuly 5, 2024 03:25
djc
djc approved these changes Jul 5, 2024
View reviewed changes
@rami3l
rami3l added this pull request to the merge queue Jul 5, 2024
Merged via the queue into rust-lang:master with commit 044083cJul 5, 2024
@heiher
heiher deleted the loongarch64-linux-musl branch July 5, 2024 15:06
@rami3lrami3l mentioned this pull request Oct 6, 2024
Closed
3 tasks
@rami3lrami3l mentioned this pull request Dec 4, 2024
Closed
3 tasks
@rami3lrami3l mentioned this pull request Jan 26, 2026
Merged
@rami3lrami3l mentioned this pull request Jun 15, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rami3lrami3lrami3l approved these changes
@djcdjcdjc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@heiher@djc@rami3l