Skip to content

feat(cli): warn when removing the default/active toolchain - #3924

Merged
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:feat/warn-toolchain-uninstall
Jul 8, 2024
Merged

feat(cli): warn when removing the default/active toolchain#3924
rami3l merged 2 commits into
rust-lang:masterfrom
rami3l:feat/warn-toolchain-uninstall

Conversation

@rami3l

@rami3lrami3l commented Jul 7, 2024

Copy link
Copy Markdown
Member

Continuation of #3637, addresses the concern 3) in #3319.

Closes#3319.

djc
djc approved these changes Jul 8, 2024
Comment threadsrc/cli/rustup_mode.rs Outdated
Comment threadsrc/cli/rustup_mode.rs Outdated
@rami3l
rami3lforce-pushed the feat/warn-toolchain-uninstall branch from 02e0fc8 to 6e41282CompareJuly 8, 2024 09:03
@rami3l
rami3l requested a review from djcJuly 8, 2024 09:04
djc
djc approved these changes Jul 8, 2024
@rami3l
rami3l added this pull request to the merge queue Jul 8, 2024
Merged via the queue into rust-lang:master with commit 2e438b0Jul 8, 2024
@rami3l
rami3l deleted the feat/warn-toolchain-uninstall branch July 8, 2024 09:39
@rami3lrami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Give a warning before uninstalling the active/default toolchain, or the last/host target for a toolchain

2 participants

@rami3l@djc