Uh oh!
There was an error while loading. Please reload this page.
docs(dev-guide): add guideline for atomic commits to the developer guide - #3969
Merged
Conversation
jtr860830
marked this pull request as draft
July 29, 2024 15:35
jtr860830
marked this pull request as ready for review
July 29, 2024 15:50
rami3l
approved these changes
Jul 30, 2024
rami3l
left a comment
Member
There was a problem hiding this comment.
@jtr860830 Looks good! Can we put this section at the beginning though?
Member
Also, it looks like this markdown was not covered by our previous API changes. |
jtr860830
commented
Jul 30, 2024
Author
OK. I'll update it. |
docs(dev-guide): put atomic commits at the beginning
rami3l
approved these changes
Jul 30, 2024
rami3l
enabled auto-merge
July 30, 2024 06:39
rami3l
added this pull request to the merge queue
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the developer guide to include information on atomic commits.