Uh oh!
There was an error while loading. Please reload this page.
fix(config): warn if host is incompatible with the toolchain in rustup default - #3980
Conversation
0d81e09 to
30f64a7Compareinstall_if_not_installed() with ensure_installed()warn_if_host_is_incompatible() in ensure_install()Uh oh!
There was an error while loading. Please reload this page.
30f64a7 to
c9cd77aComparewarn_if_host_is_incompatible() in ensure_install()rustup default
djc
left a comment
There was a problem hiding this comment.
I like the direction here, would mainly like a cleaner commit history here to make it easier to review the details.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@djc Thanks for your guidance! I'm a bit occupied with other stuff right now so I'll take another look later. Just to be sure, |
588f718 to
ed2bfdeCompareUh oh!
There was an error while loading. Please reload this page.
d426753 to
b37abe0Compare…ensure_installed()`
b37abe0 to
73d7573Compare73d7573 to
86a57c3Comparerbtcollins
commented
Aug 6, 2024
@rami3l So the point of this was to support cross-rs properly (they need non-host toolchains), while stopping people that are just following their nose from getting stuck and confused. E.g. installing an arm64 toolchain on an amd64 machine and wondering why that breaks. cross-rs should be updated by now I believe, so the appropriate action is to remove the warning and reject non-host toolchains unless the flag is provided. |
Closes#3972:
#3972 (comment)
A unified
ensure_installed()function also paves the way to addressing #2686.