Uh oh!
There was an error while loading. Please reload this page.
feat(cli)!: set log level to INFO/DEBUG on --quiet/--verbose if RUSTUP_LOG is unset - #3987
Merged
Merged
Conversation
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
from
August 10, 2024 12:44
ce06464 to
9a89b21Comparerami3l
commented
Aug 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
rami3l
marked this pull request as ready for review
August 10, 2024 12:48
rami3l
marked this pull request as draft
August 10, 2024 12:58
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
from
August 10, 2024 13:02
9a89b21 to
4dd99b0Comparerami3l
marked this pull request as ready for review
August 10, 2024 13:03
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
2 times, most recently
from
August 11, 2024 03:28
1eb60b5 to
349feecCompareDEBUG on --verbose if RUSTUP_LOG is unsetINFO/DEBUG on --quiet/--verbose if RUSTUP_LOG is unsetdjc
reviewed
Aug 19, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
from
August 22, 2024 07:01
349feec to
f1d1fdbCompare6 tasks
djc
approved these changes
Sep 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
djc
commented
Sep 4, 2024
Contributor
Sorry for the slow feedback, this is looking good! |
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
from
September 4, 2024 09:24
f1d1fdb to
915a84eCompare…`--verbose` if `RUSTUP_LOG` is unset
rami3lforce-pushed
the
feat/more-consistent-verbose
branch
from
September 4, 2024 09:27
915a84e to
b15e0a0Comparerami3l
enabled auto-merge
September 4, 2024 09:28
rami3l
added this pull request to the merge queue
Sep 4, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current setting,
debug!()lines are not printed out even if I useRUSTUP_LOG=rustup=DEBUG. This logic used to make sense when we didn't have support for directives, but now it feels a bit awkward.As a solution, I decided to follow the basic idea of #3911:
RUSTUP_LOGdecides ultimately when it's present.RUSTUP_LOGis unset,--quietor--verbosegets to decide the log verbosity.Overall, now
--quietand--verbosebehave more like what would be expected from general CLI applications.This applies to both
rustup-mode(i.e.rustup) andsetup-mode(i.e.rustup-init).