Uh oh!
There was an error while loading. Please reload this page.
fix(manifest): consider possible renames in Component::try_new() - #3991
Conversation
Uh oh!
There was an error while loading. Please reload this page.
468e944 to
ffecbc6Compare| distributable: &DistributableToolchain<'_>, | ||
| fallback_target: Option<&TargetTriple>, | ||
| ) -> Result<Self> { | ||
| let manifest = distributable.get_manifest()?; |
There was a problem hiding this comment.
It looks like distributable.components() also contains a call to distributable.get_manifest(), so doing that twice might be kind of wasteful? Is it worth doing that differently?
There was a problem hiding this comment.
@djc For the moment I'd like to keep it that way for readability, as this really isn't a hot function. I agree that the implementation is weird underneath, but as soon as I replace that with an inlined .components() I realized .get_manifest() actually calls .get_manifestation() which belongs to another layer of problems to be solved... Let's keep it this way first?
It definitely requires some refactoring afterwards anyway.
Uh oh!
There was an error while loading. Please reload this page.
Continuation of #3601. Addresses the following concern:
by @yangby-cryptape in #3166 (comment)