Skip to content

refactor(cli/common)!: deny installing a host-incompatible toolchain w/o --force-non-host - #4028

Merged
rami3l merged 5 commits into
masterfrom
feat/deny-incompat-host
Sep 22, 2024
Merged

refactor(cli/common)!: deny installing a host-incompatible toolchain w/o --force-non-host#4028
rami3l merged 5 commits into
masterfrom
feat/deny-incompat-host

Conversation

@rami3l

@rami3lrami3l commented Sep 22, 2024

Copy link
Copy Markdown
Member

Closes#3982, as discussed in #3982 (comment).

@rami3lrami3l added this to the 1.28.0 milestone Sep 22, 2024
@rami3l
rami3l requested a review from djcSeptember 22, 2024 07:34
@rami3lrami3l changed the title refactor(cli/common)!: throw an error when installing a toolchain for an incompatible hostrefactor(cli/common)!: deny installing a toolchain for an incompatible host w/o --force-non-hostSep 22, 2024
@rami3lrami3l changed the title refactor(cli/common)!: deny installing a toolchain for an incompatible host w/o --force-non-hostrefactor(cli/common)!: deny installing a host-incompatible toolchain w/o --force-non-hostSep 22, 2024
@rami3l
rami3lforce-pushed the feat/deny-incompat-host branch from aeaeffc to 3b0c072CompareSeptember 22, 2024 07:56
@rami3l
rami3lforce-pushed the feat/deny-incompat-host branch from 3b0c072 to 73348d4CompareSeptember 22, 2024 07:58
djc
djc approved these changes Sep 22, 2024
@rami3l
rami3l added this pull request to the merge queue Sep 22, 2024
Merged via the queue into master with commit 9cf01ddSep 22, 2024
@rami3l
rami3l deleted the feat/deny-incompat-host branch September 22, 2024 10:10
@rami3lrami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide how the --force-non-host flag should evolve

2 participants

@rami3l@djc