Skip to content

chore: use more workspace-wide configurations - #4061

Merged
rami3l merged 4 commits into
rust-lang:masterfrom
rami3l:chore/workspace-lints
Oct 25, 2024
Merged

chore: use more workspace-wide configurations#4061
rami3l merged 4 commits into
rust-lang:masterfrom
rami3l:chore/workspace-lints

Conversation

@rami3l

@rami3lrami3l commented Oct 24, 2024

Copy link
Copy Markdown
Member

This PR does the following cleanup WRT Cargo.toml:

This also prepares the repo for its upcoming migration to Rust 2024 by making it easier to enable rust-2024-compatibility across the project. With this change, that will look like:

[workspace.lints.rust]
rust_2018_idioms = { level = "deny", priority = -1 }
rust-2024-compatibility = { level = "warn", priority = -2 }

@rami3l
rami3l requested review from ChrisDenton and djcOctober 24, 2024 13:11

@ChrisDentonChrisDenton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace inheritance is more verbose than I'd like but only setting information in one place is definitely an advantage.

@rami3l
rami3l added this pull request to the merge queue Oct 25, 2024
Merged via the queue into rust-lang:master with commit 4678cbeOct 25, 2024
@rami3l
rami3l deleted the chore/workspace-lints branch October 25, 2024 01:28
Comment threadsrc/diskio/threaded.rs
Comment threadsrc/test/mock/clitools.rs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rami3l@djc@ChrisDenton