Uh oh!
There was an error while loading. Please reload this page.
Further refactoring of self update logic - #4412
Merged
Merged
Conversation
rami3l
commented
Jul 15, 2025
Member
Thanks for this patch! 🙏 The changes you made seemed innocent at first glance. However, the changes in the order of execution made me a little concerned, which is later confirmed by the test failures... 🤔 |
ContributorAuthor
Scoped this down to just the first commit -- I don't think I'm motivated to pursue the rest of these changes in the near future. |
rami3l
approved these changes
Sep 22, 2025
rami3l
added this pull request to the merge queue
Sep 22, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
Followup from: