Uh oh!
There was an error while loading. Please reload this page.
fix(install): default to GNU host in Cygwin/MSYS/MinGW environments (#4421) - #4497
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
192531b to
a051ee1Compare
@rami3l |
072ba3f to
f3ccd26CompareThere was a problem hiding this comment.
How is this different from the existing functionality below?
Lines 425 to 427 in 7365ab7
I presume that it's essentially the safety net to this, no? The idea here is that the issue at hand was detecting Do we address/refactor the existing detection instead? |
f3ccd26 to
0efc0f3Compare
Yes, if this PR is made to address #4421 (comment). I don't have a Cygwin test environment, but the detection seems right already to me, so this PR seems unnecessary in its current state. cc @ChrisDenton for further verification. |
63a3375 to
c213abeComparecachebag
commented
Nov 27, 2025
@rami3l
|
32283e4 to
833df04CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
833df04 to
1c5fe6aCompare1c5fe6a to
3ae8a76Comparecachebag
commented
Nov 28, 2025
rami3l
commented
Nov 28, 2025
@Petr-Lazecky Would you mind testing out this new installation script on Windows to see if the host detection has changed as expected? cc @ChrisDenton |
rami3l
commented
Nov 28, 2025
@cachebag Looks cool! Merging... |

Addresses first mentioned issue in #4421, modifying the install script to default to
x86_64-pc-windows-gnuunder Cygwin/MSYS when no --default-host is provided.The second issue requires changes in the compiled rustup-init binary (src/), which is out of scope for now