Skip to content

style: Remove wildcard imports - #4553

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
epage:wild
Oct 21, 2025
Merged

style: Remove wildcard imports#4553
rami3l merged 1 commit into
rust-lang:mainfrom
epage:wild

Conversation

@epage

@epageepage commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

This is based on review feedback from #4551.

I experimented with a clippy.toml file for "blessing" some of these, like errors, but for some reason I wasn't able to get it to work.

@epage
style: Remove wildcard imports
564be69
This is based on review feedback from rust-lang#4551.
I experimented with a `clippy.toml` file for "blessing" some of these,
like `errors`, but for some reason I wasn't able to get it to work.
@epageepage mentioned this pull request Oct 20, 2025
Merged
djc
djc approved these changes Oct 20, 2025
View reviewed changes

@djcdjc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc
djc enabled auto-merge October 20, 2025 16:01
auto-merge was automatically disabled October 20, 2025 16:27

Head branch was pushed to by a user without write access

rami3l
rami3l approved these changes Oct 21, 2025
View reviewed changes

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one question: does this change include common exceptions such as super::* in inline tests, or foo::prelude::*? I think we still want those to be excluded.

@epage

epage commented Oct 21, 2025

Copy link
Copy Markdown
ContributorAuthor

By default there are exceptions, from https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports

Wildcard imports are allowed from modules that their name contains prelude. Many crates (including the standard library) provide modules named “prelude” specifically designed for wildcard import.

Wildcard imports reexported through pub use are also allowed.

use super::* is allowed in test modules. This is defined as any module with “test” in the name.

These exceptions can be disabled using the warn-on-all-wildcard-imports configuration flag.

@djc
djc added this pull request to the merge queueOct 21, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@djc
djc added this pull request to the merge queueOct 21, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@djc

djc commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

I guess this needs a rebase? Lot of issues in the merge queue CI.

@epage

epage commented Oct 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Rebased

@rami3l
rami3l enabled auto-merge October 21, 2025 14:12
@rami3l
rami3l added this pull request to the merge queueOct 21, 2025
Merged via the queue into rust-lang:main with commit 2dc6dd7Oct 21, 2025
29 checks passed
@epage
epage deleted the wild branch October 21, 2025 15:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djcdjcdjc approved these changes
@rami3lrami3lrami3l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@epage@djc@rami3l