Skip to content

feat(cli/rustup-mode): add "Exit status" section to rustup check --help - #4696

Merged
djc merged 1 commit into
rust-lang:mainfrom
appleGun22:main
Feb 3, 2026
Merged

feat(cli/rustup-mode): add "Exit status" section to rustup check --help#4696
djc merged 1 commit into
rust-lang:mainfrom
appleGun22:main

Conversation

@appleGun22

@appleGun22appleGun22 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

In continuation to #4694.

rami3l
rami3l reviewed Jan 31, 2026
View reviewed changes
Comment threadsrc/cli/help.rs Outdated
rami3l
rami3l reviewed Jan 31, 2026
View reviewed changes

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test snapshots at the same time with SNAPSHOTS=overwrite so that the CI turns green again. Many thanks for your help!

rami3l
rami3l approved these changes Feb 1, 2026
View reviewed changes

@rami3lrami3l left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appleGun22 LGTM!

Please change the commit message and the PR title to better reflect what this patch is doing: clearly it's not about adding --help since it's already been implemented. Rather, you are adding a section about exit codes to it.

Apart from that, just squash all commits into one and we are good to go.

Many thanks again :)

@rami3lrami3l mentioned this pull request Feb 1, 2026
Merged
3 tasks
djc
djc approved these changes Feb 2, 2026
View reviewed changes
rami3l
rami3l previously requested changes Feb 2, 2026
View reviewed changes
Comment threadsrc/cli/help.rs Outdated
@rami3lrami3l changed the title Add a --help option for rustup check commandfeat(cli/rustup-mode): add "Exit status" section to rustup check --helpFeb 2, 2026
@rami3l
rami3l requested a review from djcFebruary 2, 2026 18:03
@appleGun22

appleGun22 commented Feb 2, 2026

Copy link
Copy Markdown
ContributorAuthor

@rami3l I see that you already squashed them together, but still thank you for the guidance, it was my first PR to rustup :)

djc
djc approved these changes Feb 3, 2026
View reviewed changes
@djc
djc added this pull request to the merge queueFeb 3, 2026
Merged via the queue into rust-lang:main with commit ac5a50fFeb 3, 2026
29 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djcdjcdjc approved these changes
@rami3lrami3lrami3l left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@appleGun22@djc@rami3l