Skip to content

cli: introduce semantic exit code constants for rustup check - #4700

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
dharmvr1:exit_code_constant
Feb 3, 2026
Merged

cli: introduce semantic exit code constants for rustup check#4700
rami3l merged 1 commit into
rust-lang:mainfrom
dharmvr1:exit_code_constant

Conversation

@dharmvr1

@dharmvr1dharmvr1 commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

continuation to #4694

@dharmvr1
dharmvr1 marked this pull request as draft February 2, 2026 16:29
@dharmvr1

dharmvr1 commented Feb 2, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @rami3l@ChrisDenton — quick check: is this the right approach, or should exit codes be handled differently? Also, do we want to replace all exit codes with named constants, or only the ones in the update/no-update path? Any advice would be appreciated.
thanks

@ChrisDenton

ChrisDenton commented Feb 2, 2026

Copy link
Copy Markdown
Member

Yes, it should change all exit codes to use constants.

ChrisDenton
ChrisDenton reviewed Feb 2, 2026
View reviewed changes
Comment threadsrc/cli/exit_code.rs Outdated
Comment threadsrc/cli/exit_code.rs Outdated
rami3l
rami3l requested changes Feb 2, 2026
View reviewed changes
Comment threadsrc/cli/exit_code.rs Outdated
dharmvr1
dharmvr1 commented Feb 2, 2026
View reviewed changes
Comment threadsrc/cli/rustup_mode.rs Outdated
@dharmvr1
dharmvr1 marked this pull request as ready for review February 2, 2026 23:31
rami3l
rami3l requested changes Feb 3, 2026
View reviewed changes
Comment threadsrc/utils/mod.rs Outdated
@dharmvr1
dharmvr1 requested a review from rami3lFebruary 3, 2026 14:02
rami3l
rami3l reviewed Feb 3, 2026
View reviewed changes
Comment threadsrc/cli/rustup_mode.rs Outdated
rami3l
rami3l reviewed Feb 3, 2026
View reviewed changes
Comment threadsrc/utils/mod.rs Outdated
@dharmvr1
dharmvr1 requested a review from rami3lFebruary 3, 2026 15:16
rami3l
rami3l approved these changes Feb 3, 2026
View reviewed changes

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo #4700 (comment), many thanks!

PS: Please squash all commits into one when you are done so that we can merge it.

rami3l
rami3l approved these changes Feb 3, 2026
View reviewed changes

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo #4700 (comment), many thanks!

PS: Please squash all commits into one when you are done so that we can merge it.

@dharmvr1
dharmvr1force-pushed the exit_code_constant branch 2 times, most recently from 49af512 to 1394af8CompareFebruary 3, 2026 16:24
@dharmvr1
dharmvr1 requested a review from rami3lFebruary 3, 2026 16:25
rami3l
rami3l reviewed Feb 3, 2026
View reviewed changes

@rami3lrami3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the commit message to be the same as the PR title please? "wip" is not very descriptive :]

@dharmvr1
cli: introduce semantic exit code constants for rustup check
2f2e97a
wip
complete add const name for exit_code
change const type to ExitCode
change const type to ExitCode
change to Self
adding const name for exit_code
@dharmvr1
dharmvr1force-pushed the exit_code_constant branch 2 times, most recently from 1394af8 to 2f2e97aCompareFebruary 3, 2026 16:40
@dharmvr1
dharmvr1 requested a review from rami3lFebruary 3, 2026 16:41
@rami3l
rami3l enabled auto-merge February 3, 2026 16:48
@rami3l
rami3l added this pull request to the merge queueFeb 3, 2026
Merged via the queue into rust-lang:main with commit 17dba91Feb 3, 2026
29 checks passed
@dharmvr1

dharmvr1 commented Feb 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot @rami3l@ChrisDenton for helping me get my first PR merged ,really appreciate the guidance and patience, and sorry if I bothered you a bit along the way 😅 Learned a lot from this.
I’ve got some free time right now, so if there’s any task , feel free to ping me anytime. Thanks again!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDentonChrisDentonAwaiting requested review from ChrisDenton
@rami3lrami3lAwaiting requested review from rami3l

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dharmvr1@ChrisDenton@rami3l