Skip to content

fix(ci/freebsd): install ca certs to prevent certificate-related issues - #4758

Merged
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:ci/freebsd-ca-certs-again
Mar 19, 2026
Merged

fix(ci/freebsd): install ca certs to prevent certificate-related issues#4758
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:ci/freebsd-ca-certs-again

Conversation

@rami3l

@rami3lrami3l commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Basically we are reproducing #3810 here. Not really sure if this is enough to have FreeBSD CI running again...

Closes#4749, also closes#4760, both without touching the gist.

OTOH this won't be closing #4751 since we are pinning onto the old FreeBSD version now.

@rami3l

rami3l commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I think in principle this should work but I have encountered another regression in libz-sys (maybe caused by #4753)... so now we have 3 different issues for FreeBSD now!

Update: Transferred to #4760.

@rami3lrami3l mentioned this pull request Mar 19, 2026
Closed
@rami3l
rami3lforce-pushed the ci/freebsd-ca-certs-again branch 2 times, most recently from df0db1e to 6752bb4CompareMarch 19, 2026 10:15
@rami3l

rami3l commented Mar 19, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Fix verified in https://github.com/rust-lang/rustup/actions/runs/23288593795/job/67718138780.

cc @djc to see whether the ca_root_nss reapplication could be worth investigating (I think that's unlikely our direct responsibility since the immediate problem is on Cargo's side).

@rami3l
rami3l marked this pull request as ready for review March 19, 2026 10:16
ChrisDenton
ChrisDenton reviewed Mar 19, 2026
View reviewed changes
Comment threadCargo.toml Outdated
@rami3l
rami3lforce-pushed the ci/freebsd-ca-certs-again branch from 6752bb4 to 0875b0fCompareMarch 19, 2026 10:37
@rami3l
rami3l marked this pull request as draft March 19, 2026 10:44
@rami3l
rami3lforce-pushed the ci/freebsd-ca-certs-again branch from 05df0bc to 0875b0fCompareMarch 19, 2026 13:04
@rami3l
rami3l marked this pull request as ready for review March 19, 2026 13:05
ChrisDenton
ChrisDenton approved these changes Mar 19, 2026
View reviewed changes

@ChrisDentonChrisDenton left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@rami3l
rami3l added this pull request to the merge queueMar 19, 2026
Merged via the queue into rust-lang:main with commit 5d3dee3Mar 19, 2026
58 checks passed
@rami3l
rami3l deleted the ci/freebsd-ca-certs-again branch March 19, 2026 13:55
@djc

djc commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

cc @djc to see whether the ca_root_nss reapplication could be worth investigating (I think that's unlikely our direct responsibility since the immediate problem is on Cargo's side).

Sounds like the fix is to get Cargo off of curl/OpenSSL...

@rami3l

rami3l commented Mar 19, 2026

Copy link
Copy Markdown
MemberAuthor

BTW the CI did pass on trunk again which is good news (for now)...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDentonChrisDentonChrisDenton approved these changes
@djcdjcAwaiting requested review from djc
@FranciscoTGouveiaFranciscoTGouveiaAwaiting requested review from FranciscoTGouveia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI on FreeBSD is failing due to regression in libz-sys CI on FreeBSD is failing due to SSH peer certificate or SSH remote key

3 participants

@rami3l@djc@ChrisDenton