Skip to content

Simplify downloads - #4844

Merged
djc merged 11 commits into
mainfrom
simplify-downloads
May 6, 2026
Merged

Simplify downloads#4844
djc merged 11 commits into
mainfrom
simplify-downloads

Conversation

@djc

@djcdjc commented May 3, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

@djc
djcforce-pushed the simplify-downloads branch from d6eef0e to 823dde3CompareMay 3, 2026 20:40
@rustbot

rustbot commented May 3, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rami3lrami3l self-assigned this May 3, 2026
@djc
djcforce-pushed the simplify-downloads branch from 823dde3 to 851139eCompareMay 3, 2026 20:55
rami3l
rami3l reviewed May 3, 2026
View reviewed changes
Comment threadsrc/cli/self_update.rs Outdated
Comment threadsrc/dist/download.rs
Comment threadsrc/download/mod.rs
@djc
djcforce-pushed the simplify-downloads branch 2 times, most recently from 92a68b8 to cbd4f1eCompareMay 3, 2026 21:10
FranciscoTGouveia
FranciscoTGouveia reviewed May 4, 2026
View reviewed changes
Comment threadsrc/download/mod.rs Outdated
Comment threadsrc/download/mod.rs Outdated
@djc
djcforce-pushed the simplify-downloads branch from cbd4f1e to 5f30344CompareMay 6, 2026 14:20
@djc

djc commented May 6, 2026

Copy link
Copy Markdown
ContributorAuthor

Dropped the last commit for now, which was a bit too ambitious/too much change at once. Will rework it in a few steps after this is merged.

@rami3l
rami3l self-requested a review May 6, 2026 15:59
rami3l
rami3l approved these changes May 6, 2026
View reviewed changes

@rami3lrami3l left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see how it goes :)

View changes since this review

@djc
djc added this pull request to the merge queueMay 6, 2026
Merged via the queue into main with commit d51b56cMay 6, 2026
29 checks passed
@djc
djc deleted the simplify-downloads branch May 6, 2026 19:52
@djcdjc mentioned this pull request May 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FranciscoTGouveiaFranciscoTGouveiaFranciscoTGouveia left review comments
@rami3lrami3lrami3l approved these changes

Assignees

@rami3lrami3l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djc@rustbot@rami3l@FranciscoTGouveia