Uh oh!
There was an error while loading. Please reload this page.
Default to MSVC on Windows - #842
Merged
Merged
Conversation
alexcrichton
commented
Dec 2, 2016
Member
r+ but looks like there's windows failures |
brson
commented
Dec 11, 2016
ContributorAuthor
Fixed. |
Merged
brson
commented
Dec 11, 2016
ContributorAuthor
@bors r=alexcrichton |
bors
commented
Dec 11, 2016
Contributor
📌 Commit 44323ac has been approved by |
bors
commented
Dec 11, 2016
Contributor
bors added a commit
that referenced
this pull request
Dec 11, 2016
Default to MSVC on Windows Instead of picking MSVC/GNU based on detection, just default to MSVC. During install, if MSVC is not detected provide guidance. This is more predictable and easier to explain. r? @alexcrichton
bors
commented
Dec 12, 2016
Contributor
💔 Test failed - status-travis |
Instead of picking MSVC/GNU based on detection, just default to MSVC. During install, if MSVC is not detected provide guidance. This is more predictable and easier to explain.
brson
commented
Dec 12, 2016
ContributorAuthor
@bors r+ |
bors
commented
Dec 12, 2016
Contributor
📌 Commit f384d7b has been approved by |
bors
commented
Dec 12, 2016
Contributor
bors added a commit
that referenced
this pull request
Dec 12, 2016
Default to MSVC on Windows Instead of picking MSVC/GNU based on detection, just default to MSVC. During install, if MSVC is not detected provide guidance. This is more predictable and easier to explain. r? @alexcrichton
bors
commented
Dec 12, 2016
Contributor
💔 Test failed - status-appveyor |
brson
commented
Dec 12, 2016
ContributorAuthor
@bors retry |
bors added a commit
that referenced
this pull request
Dec 12, 2016
Default to MSVC on Windows Instead of picking MSVC/GNU based on detection, just default to MSVC. During install, if MSVC is not detected provide guidance. This is more predictable and easier to explain. r? @alexcrichton
bors
commented
Dec 12, 2016
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of picking MSVC/GNU based on detection, just default to MSVC.
During install, if MSVC is not detected provide guidance.
This is more predictable and easier to explain.
r? @alexcrichton