Uh oh!
There was an error while loading. Please reload this page.
Refactor part 2: change Socket::new to only call socket(2) - #110
Merged
Conversation
These are accessible using the From implementation.
ghost
approved these changes
Oct 8, 2020
ghost
left a comment
There was a problem hiding this comment.
I agree it would be good to have a convenient constructor that sets all the advisable flags. Right now a lot of #[cfg(...)] attributes are needed to set them up properly on every platform. But that can be done later...
CollaboratorAuthor
If socket2 is going to be a fully configuration socket(2) wrapper, then the user needs to determine if things like setting CLOEXEC is desirable. The new example shows the common case of setting all those flags.
Thomasdezeeuwforce-pushed
the
refactor-p2
branch
from
October 8, 2020 12:36
bd24b6c to
16d348bCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If socket2 is going to be a fully configuration socket(2) wrapper, then
the user needs to determine if things like setting CLOEXEC is desirable.
The new example shows the common case of setting all those flags.
We should consider adding a
Socket::new_with_common_flags(), which would create a socket with all advisable flags set such as in the new example.