Add cygwin support by Berrysoft · Pull Request #568 · rust-lang/socket2

Berrysoft · 2025-04-07T03:13:30Z

This PR makes it compile on cygwin.

Thomasdezeeuw

Can we add something to the CI to ensure it keeps working?

Berrysoft · 2025-04-07T09:08:42Z

Can we add something to the CI to ensure it keeps working?

It actually doesn't work all the time, because of bugs of cygwin. To be specific, the test unix hangs. Is it OK to ignore this test on cygwin and add a job to CI?

Berrysoft · 2025-04-07T13:17:04Z

The maintainer of cygwin told me a workaround for the test unix. I have commited it.

Berrysoft · 2025-04-23T06:27:51Z

@Thomasdezeeuw ping?

Berrysoft · 2025-05-08T01:30:34Z

Could you review this PR again? @Thomasdezeeuw

Berrysoft · 2025-05-14T08:39:28Z

@Thomasdezeeuw @Darksonn Would you review again? This PR is the last blocker to build cargo on cygwin.

Thomasdezeeuw · 2025-05-14T10:33:44Z

@Thomasdezeeuw @Darksonn Would you review again? This PR is the last blocker to build cargo on cygwin.

I'm sorry to be blocking you, I've just been really busy lately and have very little spare time to review stuff (also see any pr on this repo). I'll try to give it a proper review again, but I can't promise anything.

Cygwin support in rustc This PR builds host rustc targeting cygwin. - [x] rust-lang/stacker#122 - [x] nagisa/rust_libloading#173 - [x] Detegr/rust-ctrlc#131 - [x] rust-random/getrandom#654 - [x] msys2/MSYS2-packages#5350 - [x] rust-lang#140886 - [x] rust-lang#140921 - [x] rust-lang#140973 Currently supported: * rustc * rustdoc * rustfmt * clippy Blocking: * cargo: blocked by rust-lang/socket2#568 * rust-analyzer: needs `cargo update`, fixed upstream ``` $ rustc --version --verbose rustc 1.88.0-dev binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-pc-cygwin release: 1.88.0-dev LLVM version: 20.1.4 ```

Berrysoft · 2025-05-19T03:44:58Z

@Thomasdezeeuw

I'm sorry to be blocking you, I've just been really busy lately and have very little spare time to review stuff...

Well, it's OK. Anyone has their busy time:)

It seems that you're the only active maintainer of this repo...? It's a little surprising because, I thought that the rust crates team should maintain such fundamental crate more actively:)

Cygwin support in rustc This PR builds host rustc targeting cygwin. - [x] rust-lang/stacker#122 - [x] nagisa/rust_libloading#173 - [x] Detegr/rust-ctrlc#131 - [x] rust-random/getrandom#654 - [x] msys2/MSYS2-packages#5350 - [x] rust-lang/rust#140886 - [x] rust-lang/rust#140921 - [x] rust-lang/rust#140973 Currently supported: * rustc * rustdoc * rustfmt * clippy Blocking: * cargo: blocked by rust-lang/socket2#568 * rust-analyzer: needs `cargo update`, fixed upstream ``` $ rustc --version --verbose rustc 1.88.0-dev binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-pc-cygwin release: 1.88.0-dev LLVM version: 20.1.4 ```

Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Simplify `cfg`s Co-authored-by: Alice Ryhl <aliceryhl@google.com>

It's Cygwin (Unix) only.

Thomasdezeeuw

@Berrysoft apologies again for this taking so long. I have one small nit, which moving the Socket::set_no_peercred function. To not block it any further I pushed it:
926917b, and once the CI is green I'll merge this.

Berrysoft · 2025-05-24T08:49:52Z

@Thomasdezeeuw CI's failing. You see, that's why I move the function out.

Thomasdezeeuw · 2025-05-24T08:51:53Z

@Thomasdezeeuw CI's failing. You see, that's why I move the function out.

I'll fix it. The function still has to be in the sys module.

Berrysoft · 2025-05-24T08:54:00Z

Thanks!

Thomasdezeeuw · 2025-05-24T08:54:34Z

Thanks @Berrysoft!

Berrysoft · 2025-05-24T09:05:49Z

Thank you @Thomasdezeeuw . May I ask about the release plan? When is the next release?

Co-authored-by: Alice Ryhl <aliceryhl@google.com> Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>

Thomasdezeeuw · 2025-05-24T09:28:35Z

Thank you @Thomasdezeeuw . May I ask about the release plan? When is the next release?

Not sure yet. I want drop libc from the public API, like we just did with window-sys. Hopefully I have time for that this weekend

Co-authored-by: Alice Ryhl <aliceryhl@google.com> Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>

Add cygwin support
19354e4

Thomasdezeeuw reviewed Apr 7, 2025
View reviewed changes

Berrysoft added 3 commits April 7, 2025 20:33

Fix unix test on cygwin
8e35722

Try adding cygwin target to check
71537b6

Fix flags and docs
e379cf7

Thomasdezeeuw reviewed Apr 12, 2025
View reviewed changes

Comment threadtests/socket.rs Outdated

Add set_no_peercred for cygwin
0d1639c

Berrysoft requested a review from Thomasdezeeuw April 14, 2025 14:08

Berrysoft mentioned this pull request Apr 21, 2025
Experimental cygwin host support rust-lang/cargo#15442
Closed
4 tasks

Darksonn reviewed May 8, 2025
View reviewed changes

Comment threadtests/socket.rs

Berrysoft requested a review from Darksonn May 11, 2025 14:19

Berrysoft mentioned this pull request May 13, 2025
Cygwin support in rustc rust-lang/rust#140154
Merged
8 tasks

Darksonn reviewed May 19, 2025
View reviewed changes

Comment threadsrc/sys/unix.rs Outdated

Berrysoft added 2 commits May 20, 2025 23:33

Add docs for set_no_peercred
a4cc392

Fix links in doc
c765e42

Berrysoft requested a review from Darksonn May 21, 2025 12:16

Darksonn reviewed May 21, 2025
View reviewed changes

Comment threadsrc/socket.rs Outdated
Comment threadsrc/sys/unix.rs
Comment threadsrc/sys/unix.rs Outdated
Comment threadsrc/sys/unix.rs Outdated

Apply suggestions for docs
a4ce349
Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Berrysoft requested a review from Darksonn May 22, 2025 06:34

Berrysoft added 3 commits May 22, 2025 22:27

Make set_no_peercred available on doc
e6af540

Remove cfg docsrs
d84efb3

Move set_no_peercred
8148306

Darksonn reviewed May 22, 2025
View reviewed changes

Comment threadsrc/socket.rs Outdated
Comment threadsrc/socket.rs Outdated

Apply suggestions from code review
5d7bd84
Simplify `cfg`s Co-authored-by: Alice Ryhl <aliceryhl@google.com>

Berrysoft requested a review from Darksonn May 22, 2025 23:18

Darksonn approved these changes May 23, 2025
View reviewed changes

Move Socket::set_no_peercred to src/sys/unix.rs
926917b
It's Cygwin (Unix) only.

Thomasdezeeuw approved these changes May 24, 2025
View reviewed changes

Ignore broken link
866e620

Thomasdezeeuw merged commit 1fe6c54 into rust-lang:masterMay 24, 2025

Berrysoft deleted the dev/cygwin branch May 24, 2025 08:55

Berrysoft added a commit to Berrysoft/socket2 that referenced this pull request May 24, 2025
Add cygwin support (rust-lang#568)
c82d6a6
Co-authored-by: Alice Ryhl <aliceryhl@google.com> Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>

Berrysoft mentioned this pull request May 24, 2025
Add cygwin support (#568) #578
Merged

Thomasdezeeuw added a commit that referenced this pull request May 24, 2025
Add cygwin support (#568) (#578)
d71f29b
Co-authored-by: Alice Ryhl <aliceryhl@google.com> Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>

kanarus mentioned this pull request Aug 1, 2025
chore: fix nio version to =0.0.0 to successfully compile ohkami-rs/mews#29
Closed

Uh oh!

Conversation

Berrysoft commented Apr 7, 2025

Uh oh!

Thomasdezeeuw left a comment

Choose a reason for hiding this comment

Uh oh!

Berrysoft commented Apr 7, 2025

Uh oh!

Berrysoft commented Apr 7, 2025

Uh oh!

Uh oh!

Berrysoft commented Apr 23, 2025

Uh oh!

Berrysoft commented May 8, 2025

Uh oh!

Uh oh!

Berrysoft commented May 14, 2025

Uh oh!

Thomasdezeeuw commented May 14, 2025

Uh oh!

Berrysoft commented May 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Thomasdezeeuw left a comment

Choose a reason for hiding this comment

Uh oh!

Berrysoft commented May 24, 2025

Uh oh!

Thomasdezeeuw commented May 24, 2025

Uh oh!

Berrysoft commented May 24, 2025

Uh oh!

Thomasdezeeuw commented May 24, 2025

Uh oh!

Berrysoft commented May 24, 2025

Uh oh!

Thomasdezeeuw commented May 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants