add back Domain::ipv{4,6}

[Keruspe]

This restores backward compatibility

Fixes#93
Fixes#95

[baoyachi]

How can this kind of mistake be avoided with use https://semver.org/ in cargo?

[Keruspe]

@stjepang Could we get a quickfix 0.3.14?

[Keruspe]

How can this kind of mistake be avoided with use https://semver.org/ in cargo?

semverver helps avoiding this kind of mistakes I think

[baoyachi]

Taking this event as an example, an hour has passed since the latest version of the update. Developers around the world have indirectly referenced the library, which has led to the failure of the project to compile normally. This control is not in the hands of developers, but in the authors who rely on the library, and the project control is lost。

[ghost]

Thanks!

[nevi-me]

@baoyachi semver depends on developer interpretation, so mistakes like this will happen once in a while. The changes that led to this issue seem to have been made around April, so without some external pre-release test from crates that depend on this one, I assume it would have been impossible to discover this issue until the new version was released.

[ghost]

Published v0.3.14

[ghost]

Really sorry about this! :( Let me know if this resolves the issue - I'll be online and respond promptly. You can also reach me on Discord if need be.

[nevi-me]

Really sorry about this! :( Let me know if this resolves the issue - I'll be online and respond promptly. You can also reach me on Discord if need be.

No worries, it happens :)

It hasn't resolved the issue, there's now another one.

error[E0599]: no function or associated item named `stream` found for struct `socket2::Type` in the current scope
--> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:44
|
559 | let socket = Socket::new(domain,Type::stream(),Some(Protocol::tcp()))?;
| ^^^^^^ function or associated item not found in `socket2::Type`
error[E0599]: no function or associated item named `tcp` found for struct `socket2::Protocol` in the current scope
--> C:\Users\nevi\.cargo\registry\src\github.com-1ecc6299db9ec823\hyper-0.13.7\src\client\connect\http.rs:559:69
|
559 | let socket = Socket::new(domain,Type::stream(),Some(Protocol::tcp()))?;
| ^^^ function or associated item not found in `socket2::Protocol`

[nevi-me]

Would it be safer to instead yank 0.3.13 and 0.3.14, and release the update as 0.4.0 @stjepang ?

[ghost]

Ugh. Okay I'm going to yank this and postpone a new release until we figure this out.