Skip to content

improve error handling - #116

Merged
nagisa merged 16 commits into
rust-lang:masterfrom
lovasoa:improve_error_handling
Feb 21, 2025
Merged

improve error handling#116
nagisa merged 16 commits into
rust-lang:masterfrom
lovasoa:improve_error_handling

Conversation

@lovasoa

@lovasoalovasoa commented Feb 18, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@peter-tothpeter-toth mentioned this pull request Feb 19, 2025
Merged
1 task
nagisa
nagisa reviewed Feb 19, 2025
View reviewed changes

@nagisanagisa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be fine to return None from guess_os_stack when procfs isn't available, but in principle it also doesn't change that for most intents and purposes systems configured that way are sorta broken for the purposes of *-linux-gnu targets at least.

Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
@lovasoa

lovasoa commented Feb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

@nagisa I reorganized guess_os_stack to have separate files per backend, addressed your comments, and added more error handling where it was missing on other platforms.

@nagisa
nagisa merged commit 5eed05f into rust-lang:masterFeb 21, 2025
@lovasoa
lovasoa deleted the improve_error_handling branch February 21, 2025 13:04
@lovasoa

lovasoa commented Feb 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Great, thank you very much @nagisa !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagisanagisanagisa left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion error: when pthread returns an error, this library crashes the entire program

2 participants

@lovasoa@nagisa