Skip to content

Support panicking and make unsupported platforms a nop - #5

Closed
oli-obk wants to merge 12 commits into
rust-lang:masterfrom
oli-obk:master
Closed

Support panicking and make unsupported platforms a nop#5
oli-obk wants to merge 12 commits into
rust-lang:masterfrom
oli-obk:master

Conversation

@oli-obk

@oli-obkoli-obk commented Nov 2, 2018

Copy link
Copy Markdown
Contributor

alexcrichton
alexcrichton reviewed Nov 2, 2018
View reviewed changes
Comment threadsrc/lib.rs Outdated
alexcrichton
alexcrichton reviewed Nov 2, 2018
View reviewed changes
Comment threadsrc/lib.rs Outdated
alexcrichton
alexcrichton reviewed Nov 3, 2018
View reviewed changes
Comment threadbuild.rs Outdated
alexcrichton
alexcrichton reviewed Nov 3, 2018
View reviewed changes
Comment threadCargo.toml Outdated
alexcrichton
alexcrichton reviewed Nov 3, 2018
View reviewed changes
Comment threadsrc/lib.rs Outdated
@alexcrichton

alexcrichton commented Nov 3, 2018

Copy link
Copy Markdown
Member

It looks like MSVC is having trouble with the panicking code?

(MinGW on appveyor failures can probably be ignored)

@oli-obk

oli-obk commented Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

I'll try to find a windows machine to debug this on

alexcrichton
alexcrichton reviewed Nov 6, 2018
View reviewed changes
Comment threadbuild.rs
alexcrichton
alexcrichton reviewed Nov 6, 2018
View reviewed changes
Comment threadsrc/lib.rs Outdated
@alexcrichton

alexcrichton commented Nov 8, 2018

Copy link
Copy Markdown
Member

FWIW I think a git dep in rustc should be sufficient for profiling, but if you need me to publish anything here just let me know!

@oli-obkoli-obk mentioned this pull request Nov 16, 2018
Closed
@alexcrichton

alexcrichton commented Dec 10, 2018

Copy link
Copy Markdown
Member

I've cleaned this up a bit and moved it over to https://github.com/alexcrichton/stacker/pull/11 so I'm gonna close this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichtonalexcrichtonalexcrichton left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oli-obk@alexcrichton