Skip to content

Fix i8mm feature with bootstrap compiler. - #1252

Merged
Amanieu merged 1 commit into
rust-lang:masterfrom
ehuss:i8mm-bootstrap
Nov 15, 2021
Merged

Fix i8mm feature with bootstrap compiler.#1252
Amanieu merged 1 commit into
rust-lang:masterfrom
ehuss:i8mm-bootstrap

Conversation

@ehuss

Copy link
Copy Markdown
Contributor

The beta compiler (1.57) does not support the i8mm feature. This fixes a build failure by not enabling it when bootstrapping.

@rust-highfive

Copy link
Copy Markdown

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@ehuss

Copy link
Copy Markdown
ContributorAuthor

I'm not certain that this will work, as I do not have an arm system to test on.

@ehussehuss mentioned this pull request Nov 14, 2021
@SparrowLii

Copy link
Copy Markdown
Member

If we accept this change, does it mean that we need to change it again when the beta compiler supports the i8mm feature?

@ehuss

Copy link
Copy Markdown
ContributorAuthor

Yes, I believe that is what is usually done (#1150 for example).

@Amanieu
Amanieu merged commit 05e8072 into rust-lang:masterNov 15, 2021
@ehussehuss mentioned this pull request Nov 19, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2021
Update stdarch
5 commits in 815d55c..cfba59f
2021-11-08 00:58:47 +0000 to 2021-11-19 01:29:04 +0000
- Work-around buggy Intel chips erroneously reporting BMI1/BMI2 support (rust-lang/stdarch#1249)
- complete armv8 instructions (rust-lang/stdarch#1256)
- Fix i8mm feature with bootstrap compiler. (rust-lang/stdarch#1252)
- Fix unused link_name attribute. (rust-lang/stdarch#1251)
- Add remaining insturctions (rust-lang/stdarch#1250)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ehuss@rust-highfive@SparrowLii@Amanieu