Stabilize Ratified RISC-V Target Features - #1476

Merged
Amanieu merged 1 commit into
rust-lang:masterfrom
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged

Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom
coastalwhite:stabilize-riscv-target-features

Conversation

@coastalwhite

@coastalwhitecoastalwhite commented Oct 4, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.

Specifically, this PR stabilizes the:

  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0

When this is merged, a PR for the main Rust repository can be created.

@rustbot

rustbot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@Amanieu

Amanieu commented Oct 6, 2023

Copy link
Copy Markdown
Member

Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?

@coastalwhitecoastalwhite mentioned this pull request Oct 6, 2023
Merged
@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch from fec1880 to eb43384CompareOctober 11, 2023 09:53
@coastalwhite

coastalwhite commented Oct 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?

@Amanieu

Amanieu commented Oct 19, 2023

Copy link
Copy Markdown
Member

The other FCP is sufficient.

@bors

bors commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch from eb43384 to b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite

coastalwhite commented Nov 3, 2023

Copy link
Copy Markdown
ContributorAuthor

I just rebased this onto the master branch and force pushed. I think this is mergable now.

@Amanieu

Amanieu commented Nov 18, 2023

Copy link
Copy Markdown
Member

Can you bump the version number in the attributes to 1.76 (current nightly)?

@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch from b4c4a89 to d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite

coastalwhite commented Nov 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Can you bump the version number in the attributes to 1.76 (current nightly)?

Done

Amanieu
Amanieu reviewed Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs Outdated
Comment threadcrates/std_detect/src/detect/arch/riscv.rs Outdated
Comment threadcrates/std_detect/src/detect/arch/riscv.rs Outdated
@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch 2 times, most recently from 327062c to 64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu reviewed Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs Outdated
Comment on lines +158 to +159
@FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
/// "Zb" Standard Extension for Bit Manipulation

@AmanieuAmanieuNov 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

@coastalwhitecoastalwhiteNov 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.

@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch from 64a5bbe to 2cd47a5CompareNovember 23, 2023 14:31
@Amanieu

Amanieu commented Nov 30, 2023

Copy link
Copy Markdown
Member

CI should be fixed, can you rebase?

@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed the stabilize-riscv-target-features branch from 2cd47a5 to 2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite

coastalwhite commented Nov 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Done 😄

@Amanieu
Amanieu merged commit 821a641 into rust-lang:masterNov 30, 2023
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit to Kobzol/portable-simd that referenced this pull request Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Stabilize Ratified RISC-V Target Features - #1476
Merged
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Nov 30, 2023
Merged
Stabilize Ratified RISC-V Target Features#1476
Amanieu merged 1 commit into
rust-lang:masterfrom 
coastalwhite:stabilize-riscv-target-features
Conversation
@coastalwhite
@coastalwhitecoastalwhite
commented
Oct 4, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
As shortly discussed on Zulip

(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit PR the ratified RISC-V instruction bases and extensions.
Specifically, this PR stabilizes the:
  • Instruction-Fetch Fence (Zifencei) on v2.0
  • Control and Status Register (Zcsr) on v2.0
  • Pause Hint (Zihintpause) on v2.0
  • Zicntr and Zihpm were ratified March 2023
  • Total Store Ordering (Ztso) on v1.0
  • Supervisor-level Instructions (S) on v1.12
  • Atomic Instructions (A) on v2.0
  • Compressed Instructions (C) on v2.0
  • Double-Precision Floating-Point (D) on v2.2
  • Embedded Base (E) (Given as RV32E / RV64E) on v2.0
  • Single-Precision Floating-Point (F) on v2.2
  • Integer Multiplication and Division (M) on v2.0
  • Vector Operations (V) on v1.0
  • Bit Manipulations (B) on v1.0 listed as zba, zbc, zbs
  • Scalar Cryptography (Zk) v1.0.1 listed as zk, zkn, zknd, zkne, zknh, zkr, zks, zksed, zksh, zkt, zbkb, zbkczkbx
  • Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0
  • Half-Precision Floating-Point (Zfh) on v1.0
  • Minimal Half-Precision Floating-Point (Zfhmin) on v1.0
  • Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0
  • Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0
  • Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0
When this is merged, a PR for the main Rust repository can be created.
@rustbot
rustbot
commented
Oct 4, 2023

Copy link


Copy Markdown

Collaborator
r? @Amanieu
(rustbot has picked a reviewer for you, use r? to override)
@Amanieu
Amanieu
commented
Oct 6, 2023

Copy link


Copy Markdown

Member
Could you open a PR for rust-lang/rust first which stabilizes the compiler-level feature names so that we can start a T-lang FCP on that?
@coastalwhitecoastalwhite
mentioned this pull request
Oct 6, 2023
 Merged

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
fec1880 to
eb43384CompareOctober 11, 2023 09:53
@coastalwhite
coastalwhite
commented
Oct 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Do I need to request a separate FCP for this PR or is this also okay to merge if rust-lang/rust#116485 passes the FCP?
@Amanieu
Amanieu
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
The other FCP is sufficient.
@bors
bors
commented
Oct 29, 2023

Copy link


Copy Markdown

Contributor
☔ The latest upstream changes (presumably 68b3ddf) made this pull request unmergeable. Please resolve the merge conflicts.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2023
@bors
Auto merge ofrust-lang#116485- coastalwhite:stabilize-riscv-target-…
91bbdd9
…features, r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by rust-lang#44839. This is also a part of rust-lang#114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 2, 2023
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
21deae8
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
eb43384 to
b4c4a89CompareNovember 3, 2023 10:47
@coastalwhite
coastalwhite
commented
Nov 3, 2023

Copy link


Copy Markdown

ContributorAuthor
I just rebased this onto the master branch and force pushed. I think this is mergable now.
@Amanieu
Amanieu
commented
Nov 18, 2023

Copy link


Copy Markdown

Member
Can you bump the version number in the attributes to 1.76 (current nightly)?
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
b4c4a89 to
d1e69d3CompareNovember 19, 2023 13:20
@coastalwhite
coastalwhite
commented
Nov 19, 2023

Copy link


Copy Markdown

ContributorAuthor
Can you bump the version number in the attributes to 1.76 (current nightly)?
Done
Amanieu
Amanieu
reviewed
Nov 19, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated

@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
2 times, most recently
from
327062c to
64a5bbeCompareNovember 22, 2023 11:05
Amanieu
Amanieu
reviewed
Nov 23, 2023
View reviewed changes
Comment threadcrates/std_detect/src/detect/arch/riscv.rs
Outdated


Comment on lines

+158
 to 
+159

 @FEATURE: #[stable(feature = "riscv_ratified", since = "1.76.0")] zb: "zb";
 /// "Zb" Standard Extension for Bit Manipulation
@AmanieuAmanieuNov 23, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.
@coastalwhitecoastalwhiteNov 23, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It was still unstaged on my pc. This should be fixed now.
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
64a5bbe to
2cd47a5CompareNovember 23, 2023 14:31
@Amanieu
Amanieu
commented
Nov 30, 2023

Copy link


Copy Markdown

Member
CI should be fixed, can you rebase?
@coastalwhite
Stabilize Ratified RISC-V Target Features
2e6dcf2
As shortly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704), this commit stabilizes the ratified RISC-V instruction bases and extensions.
Specifically, this commit stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* Integer Multiplication and Division (M) on v2.0
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
@coastalwhite
coastalwhiteforce-pushed
the
stabilize-riscv-target-features
branch
from
2cd47a5 to
2e6dcf2CompareNovember 30, 2023 20:24
@coastalwhite
coastalwhite
commented
Nov 30, 2023

Copy link


Copy Markdown

ContributorAuthor
Done 😄
@Amanieu
Amanieu
merged commit 821a641
into
rust-lang:masterNov 30, 2023
lnicola pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
24f4712
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
RalfJung pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
8c7bc3e
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Kobzol pushed a commit
to Kobzol/portable-simd
that referenced
this pull request
Feb 3, 2026
@bors
Auto merge of #116485 - coastalwhite:stabilize-riscv-target-features,…
1b056ba
… r=Amanieu
Stabilize Ratified RISC-V Target Features
Stabilization PR for the ratified RISC-V target features. This stabilizes some of the target features tracked by #44839. This is also a part of #114544 and eventually needed for the RISC-V part of rust-lang/rfcs#3268.
There is a similar PR for the the stdarch crate which can be found at rust-lang/stdarch#1476.
This was briefly discussed on Zulip
(https://rust-lang.zulipchat.com/#narrow/stream/250483-t-compiler.2Frisc-v/topic/Stabilization.20of.20RISC-V.20Target.20Features/near/394793704).
Specifically, this PR stabilizes the:
* Atomic Instructions (A) on v2.0
* Compressed Instructions (C) on v2.0
* ~Double-Precision Floating-Point (D) on v2.2~
* ~Embedded Base (E) (Given as `RV32E` / `RV64E`) on v2.0~
* ~Single-Precision Floating-Point (F) on v2.2~
* Integer Multiplication and Division (M) on v2.0
* ~Vector Operations (V) on v1.0~
* Bit Manipulations (B) on v1.0 listed as `zba`, `zbc`, `zbs`
* Scalar Cryptography (Zk) v1.0.1 listed as `zk`, `zkn`, `zknd`, `zkne`, `zknh`, `zkr`, `zks`, `zksed`, `zksh`, `zkt`, `zbkb`, `zbkc` `zkbx`
* ~Double-Precision Floating-Point in Integer Register (Zdinx) on v1.0~
* ~Half-Precision Floating-Point (Zfh) on v1.0~
* ~Minimal Half-Precision Floating-Point (Zfhmin) on v1.0~
* ~Single-Precision Floating-Point in Integer Register (Zfinx) on v1.0~
* ~Half-Precision Floating-Point in Integer Register (Zhinx) on v1.0~
* ~Minimal Half-Precision Floating-Point in Integer Register (Zhinxmin) on v1.0~
r? `@Amanieu`
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

T-libs-api

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coastalwhite@rustbot@Amanieu@bors