Stabilize Wasm relaxed SIMD by daxpedda · Pull Request #1494 · rust-lang/stdarch

daxpedda · 2023-10-31T22:36:20Z

This is for rust-lang/rust#117468, which has to be accepted (but not merged) first before this can be merged.

I also changed some functions to use the proper LLVM instructions instead of their aliases, see #1396.
Additionally I added aliases to unsigned variants when appropriate (as is done in SIMD128).

Fixes#1396.
~~Depends on #1523.~~

rustbot · 2023-10-31T22:36:25Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

daxpedda · 2023-10-31T22:47:01Z


 mod relaxed_simd;
-#[unstable(feature = "stdarch_wasm_relaxed_simd", issue = "111196")]
+#[stable(feature = "stdarch_wasm_relaxed_simd", since = "CURRENT_RUSTC_VERSION")]


Is CURRENT_RUSTC_VERSION how it's done in stdarch as well?

No, you have to put in the actual version. Since stdarch is a submodule it doesn't get updated by the release time.

Alright, will do that after the FCP in rust-lang/rust#117468.

I tentatively assigned Rust v1.81 to make this mergable.

daxpedda · 2024-02-06T10:21:23Z

This is currently based on #1523.

daxpedda · 2024-02-14T15:21:46Z

Rebased onto master after #1523 was merged.

daxpedda · 2024-02-14T15:32:08Z

@Amanieu I believe the current CI failure is not coming from this PR?
https://github.com/rust-lang/stdarch/actions/runs/7903504132/job/21571575006?pr=1494

Amanieu · 2024-02-15T00:18:56Z

This should fix itself when rust-lang/rust#121088 is merged.

nikic · 2024-02-16T09:50:36Z

I've put up #1528 for the aarch64 failure.

CryZe · 2024-02-16T12:07:19Z

I just noticed that there's a bunch of (aliased) "intrinsics" seemingly missing such as u8x16_relaxed_swizzle. Those should probably be added before stabilizing.

daxpedda · 2024-02-16T12:32:35Z

I just noticed that there's a bunch of (aliased) "intrinsics" seemingly missing such as u8x16_relaxed_swizzle. Those should probably be added before stabilizing.

Do you mean adding u8x16_relaxed_swizzle but aliasing it internally to i8x16.relaxed_swizzle? Is that a thing that's done?

CryZe · 2024-02-16T12:59:47Z

Yeah that's done for the normal swizzle for example. And many other instructions.

…wiser Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494Closesrust-lang#111196.

…crichton Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494Closesrust-lang#111196.

…ichton Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: rust-lang#111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494Closesrust-lang#111196.

Stabilize Wasm relaxed SIMD This PR stabilizes [Wasm relaxed SIMD](https://github.com/WebAssembly/relaxed-simd) which has already reached [phase 4](https://github.com/WebAssembly/proposals/tree/04fa8c810e1dc99ab399e41052a6e427ee988180?tab=readme-ov-file#phase-4---standardize-the-feature-wg). Tracking issue: #111196 Implementation PR: rust-lang/stdarch#1393 Documentation: rust-lang/reference#1421 Stdarch: rust-lang/stdarch#1494 Closes #111196.

rustbot assigned Amanieu Oct 31, 2023

daxpedda mentioned this pull request Oct 31, 2023
Stabilize Wasm relaxed SIMD rust-lang/rust#117468
Merged

daxpedda force-pushed the relaxed-simd branch from 44c4277 to b654a03Compare October 31, 2023 22:46

daxpedda commented Oct 31, 2023
View reviewed changes

daxpedda force-pushed the relaxed-simd branch 2 times, most recently from 3385000 to 7bbd5f7Compare February 6, 2024 10:20

daxpedda force-pushed the relaxed-simd branch from 7bbd5f7 to 6946476Compare February 14, 2024 15:21

daxpedda force-pushed the relaxed-simd branch from 6946476 to 6809048Compare February 14, 2024 15:26

daxpedda force-pushed the relaxed-simd branch from 6809048 to f911445Compare February 16, 2024 07:51

daxpedda force-pushed the relaxed-simd branch from f911445 to 73576d7Compare February 16, 2024 11:02

daxpedda force-pushed the relaxed-simd branch 3 times, most recently from 371ccb0 to 325b8dbCompare February 21, 2024 16:41

daxpedda force-pushed the relaxed-simd branch from 325b8db to c3cca2eCompare February 25, 2024 10:28

daxpedda force-pushed the relaxed-simd branch from c3cca2e to 59a767fCompare May 19, 2024 20:04

daxpedda force-pushed the relaxed-simd branch from 59a767f to a54dac6Compare June 11, 2024 14:04

daxpedda added 3 commits June 27, 2024 09:36

Stabilize Wasm relaxed SIMD
a400e9c

Add unsigned aliases
92cbaed

Assign Rust v1.81.0
3f0273c

daxpedda force-pushed the relaxed-simd branch from a54dac6 to 3f0273cCompare June 27, 2024 07:38

daxpedda marked this pull request as ready for review June 27, 2024 07:39

Amanieu merged commit 7783b01 into rust-lang:masterJun 27, 2024

Navigation Menu

Uh oh!

Stabilize Wasm relaxed SIMD - #1494

Stabilize Wasm relaxed SIMD#1494
Amanieu merged 3 commits into
rust-lang:masterfrom
daxpedda:relaxed-simd

daxpedda commented Oct 31, 2023•
edited
Loading

Uh oh!

rustbot commented Oct 31, 2023

Uh oh!

daxpeddaOct 31, 2023

Uh oh!

AmanieuOct 31, 2023

Uh oh!

daxpeddaOct 31, 2023

Uh oh!

daxpeddaJun 27, 2024

Uh oh!

daxpedda commented Feb 6, 2024

Uh oh!

daxpedda commented Feb 14, 2024

Uh oh!

daxpedda commented Feb 14, 2024

Uh oh!

Amanieu commented Feb 15, 2024

Uh oh!

nikic commented Feb 16, 2024

Uh oh!

CryZe commented Feb 16, 2024•
edited
Loading

Uh oh!

daxpedda commented Feb 16, 2024

Uh oh!

CryZe commented Feb 16, 2024•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

daxpedda commented Oct 31, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 31, 2023

Uh oh!

daxpeddaOct 31, 2023

Choose a reason for hiding this comment

Uh oh!

AmanieuOct 31, 2023

Choose a reason for hiding this comment

Uh oh!

daxpeddaOct 31, 2023

Choose a reason for hiding this comment

Uh oh!

daxpeddaJun 27, 2024

Choose a reason for hiding this comment

Uh oh!

daxpedda commented Feb 6, 2024

Uh oh!

daxpedda commented Feb 14, 2024

Uh oh!

daxpedda commented Feb 14, 2024

Uh oh!

Amanieu commented Feb 15, 2024

Uh oh!

nikic commented Feb 16, 2024

Uh oh!

CryZe commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daxpedda commented Feb 16, 2024

Uh oh!

CryZe commented Feb 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daxpedda commented Oct 31, 2023•
edited
Loading

CryZe commented Feb 16, 2024•
edited
Loading

CryZe commented Feb 16, 2024•
edited
Loading