Uh oh!
There was an error while loading. Please reload this page.
add swap_bytes - #509
Closed
TheIronBorn wants to merge 2 commits into
Closed
Conversation
This was referenced Jun 29, 2018
TheIronBornforce-pushed
the
swap_bytes
branch
3 times, most recently
from
June 29, 2018 21:35
901d9ec to
6d304d2CompareTheIronBorn
commented
Jun 29, 2018
ContributorAuthor
I can't find a decent way to import the shuffle intrinsics |
TheIronBornforce-pushed
the
swap_bytes
branch
5 times, most recently
from
June 29, 2018 22:44
f5d7752 to
e0c27a7Comparegnzlbg
commented
Jun 30, 2018
Contributor
You just need to do like x86 does and use the |
ContributorAuthor
I'm trying |
ContributorAuthor
Using what I can see as the exact same technique used in #![allow(unused)]use coresimd::simd::*;pub(crate)traitSwapBytes{fnswap_bytes(self) -> Self;}implSwapBytesforu8x2{fnswap_bytes(self) -> Self{use coresimd::simd_llvm::simd_shuffle2;let shuffled:u8x2 = unsafe{simd_shuffle2(self,self,[1,0])};
u8x2::from_bits(shuffled)}}Gets Not sure what's going on. |
gnzlbg
commented
Jul 6, 2018
Contributor
If you update or send a PR it is easier for me to look at it. |
TheIronBorn
commented
Jul 6, 2018
ContributorAuthor
I found a solution. The weird crate structure was throwing me. Pull coming soon |
gnzlbg
commented
Jul 6, 2018
Contributor
what was the problem? |
TheIronBorn
commented
Jul 6, 2018
via email
ContributorAuthor
Macro scopes combined with importing the crate modules by path. …Sent from my mobile device On Jul 6, 2018, at 10:11, gnzlbg ***@***.***> wrote:
what was the problem?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could add some
llvm.bswapimplementations.https://godbolt.org/g/jH2FCR suggests this could be better.