Skip to content

fix _mm_castsi128_pd and _mm_castpd_si128 impls - #581

Merged
alexcrichton merged 5 commits into
rust-lang:masterfrom
kazcw:master
Oct 23, 2018
Merged

fix _mm_castsi128_pd and _mm_castpd_si128 impls#581
alexcrichton merged 5 commits into
rust-lang:masterfrom
kazcw:master

Conversation

@kazcw

@kazcwkazcw commented Oct 23, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

The _mm_castX_Y SSE intrinsics are "reinterpreting" casts; LLVM's
simd_cast is a "converting" cast. Replace simd_casts with mem::transmute.
Fixesrust-lang/rust#55249

@kazcw
fix _mm_castsi128_pd and _mm_castpd_si128 impls
abbebce
The _mm_castX_Y SSE intrinsics are "reinterpreting" casts; LLVM's
simd_cast is a "converting" cast. Replace simd_cast with mem::transmute.
Fixes #55249
@alexcrichton

alexcrichton commented Oct 23, 2018

Copy link
Copy Markdown
Member

Thanks for this! This looks correct to me, and I'm trying to dig into why CI is failing now.

@alexcrichton

alexcrichton commented Oct 23, 2018

Copy link
Copy Markdown
Member

Ok the segfault here is not the fault of this PR. I'm looking into pinning CI temoprarily to an older nightly to fix CI

gnzlbg
gnzlbg approved these changes Oct 23, 2018
View reviewed changes

@gnzlbggnzlbg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@alexcrichton
alexcrichton merged commit 431766a into rust-lang:masterOct 23, 2018
@alexcrichton

alexcrichton commented Oct 23, 2018

Copy link
Copy Markdown
Member

@kazcw if you're extra enterprising, the next step here is to update the src/stdsimd submodule in rust-lang/rust, and that should be all that's necessary to get the fix into nightly!

@kazcw

kazcw commented Oct 23, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton Cool! rust-lang/rust#55291

@MaskRay

MaskRay commented Jan 2, 2023

Copy link
Copy Markdown

# It's not clear why -Z plt=yes is required here. Probably a bug in LLVM. # If you can remove it and CI passes, please feel free to do so!`

Likely due to rust-lang/rust#54592 switching the default.

If you use lld, it didn't support -fno-plt general-dynamic/local-dynamic TLS models until 2022-12-31 (llvm/llvm-project@8dc7366).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gnzlbggnzlbggnzlbg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

simd sse2: si128/pd casts emitting conversions

4 participants

@kazcw@alexcrichton@MaskRay@gnzlbg