Uh oh!
There was an error while loading. Please reload this page.
Implement all MSA Intrinsics - #709
Conversation
gnzlbg
left a comment
There was a problem hiding this comment.
This needs a thorough review, but two things stand out:
- the msa module should use newtype vector types instead of re-exporting the ones from the
simdmodule - this is not built in CI AFAICT, so this will need at least CI that builds with
msaenabled (a qemu build job that runs the tests on CI can be added in a subsequent PR though)
Uh oh!
There was an error while loading. Please reload this page.
gnzlbg
commented
Apr 5, 2019
This is looking really good, thank you for working on this. Do you think you would be able to add a couple of buildjobs that build the library with |
rbirdic
commented
Apr 5, 2019
@gnzlbg Can I repurpose existing MIPS buildjobs for that or do I need to add new ones? |
gnzlbg
commented
Apr 5, 2019
You can repurpose them, by adding a case for mips here (https://github.com/rust-lang-nursery/stdsimd/blob/master/ci/run.sh#L64) and then enabling MSA. I think you might want to add new build jobs for the new |
Rustc changes which provide mips r6 support have been recently added (1.35-nightly). I don't think there is rustup target for mipsisa64r6*-unknown-linux-gnuabi64 available. |
gnzlbg
commented
Apr 8, 2019
@rbirdic rustup is not required, you can use xargo to recompile core for those targets, the |
wzssyqa
commented
Apr 9, 2019
@rbirdic in ci/run.sh, you seem not taking care about r6: |
gnzlbg
commented
Apr 9, 2019
@wzssyqa a |
gnzlbg
commented
Apr 9, 2019
So this looks good enough to merge for me. Build jobs for the |
gnzlbg
commented
Apr 9, 2019
How soon do you need these intrinsics on nightly Rust? I would be more comfortable if we were to set up running the run-time tests on CI before landing these upstream. |
rbirdic
commented
Apr 10, 2019
I am ok with adding test first. |
Fixes#170