Uh oh!
There was an error while loading. Please reload this page.
[breaking change] Fix pointer validation in stdsimd-verify - #746
Merged
Conversation
gnzlbg
commented
Apr 26, 2019
ContributorAuthor
cc @dchammond |
alexcrichton
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alexcrichton this PR makes stdsimd-verify treat mut and const pointer and references differently. We had a breaking changes due to incorrect pointer mutability already (e.g. #576), and I hope this will prevent at least the more obvious ones as the AVX-512 intrinsics get added.
Two breaking changes are introduced:
_mm_clflushhad an incorrect API, the pointer should have been aconstpointer, but it was amutoneI'll propose to merge something like this to stdsimd, and then do a crater run in the PR to rust-lang/rust.