Uh oh!
There was an error while loading. Please reload this page.
Replace module MIN/MAX and min/max_value() with assoc consts - #843
Conversation
rust-highfive
commented
Mar 27, 2020
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
faern
commented
Mar 27, 2020
The failing check seems to be spurious, or at least not caused by my changes in this PR. |
Amanieu
commented
Mar 29, 2020
Can you rebase now that #845 is merged? |
0109546 to
46b9c31Comparefaern
commented
Mar 29, 2020
Done |
Since it's recommended use use the integer associated constants for new code from Rust 1.43 the docs better mention them instead of the older slightly less recommended versions.
EDIT: Corresponding PR doing the same thing in most of the
rustrepo comes soon. But I thought submodules get their own PRs(?). Please enlighten me to what the procedure is.