Skip to content

Switch the library to ArrayRef - #415

Merged
Dirreke merged 4 commits into
rust-ndarray:masterfrom
akern40:reference-type-full
Dec 29, 2025
Merged

Switch the library to ArrayRef#415
Dirreke merged 4 commits into
rust-ndarray:masterfrom
akern40:reference-type-full

Conversation

@akern40

Copy link
Copy Markdown
Contributor

This is a large PR that repeatedly does a simple process: find locations of &ArrayBase and replace it with &ArrayRef, then remove any unused generics. The only change that isn't in this theme is for EigGeneralized, for which we need a new trait to provide a tuple-friendly implementation (see #412 for more details).

Closes#412

@akern40
akern40 requested a review from DirrekeDecember 24, 2025 18:18
@codecov

codecovBot commented Dec 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.15190% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (edff246) to head (729edc0).
⚠️ Report is 19 commits behind head on master.

Files with missing linesPatch %Lines
ndarray-linalg/src/tridiagonal.rs14.28%18 Missing ⚠️
ndarray-linalg/src/krylov/householder.rs66.66%3 Missing ⚠️
ndarray-linalg/src/solveh.rs75.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #415 +/- ##
==========================================
- Coverage 87.65% 87.35% -0.31% 
==========================================
Files 65 65 Lines 3895 3937 +42 ==========================================
+ Hits 3414 3439 +25 - Misses 481 498 +17 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dirreke
Dirreke merged commit 4520265 into rust-ndarray:masterDec 29, 2025
10 of 12 checks passed
@DirrekeDirreke mentioned this pull request Jan 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to ArrayRef instead of ArrayBase

2 participants

@akern40@Dirreke