Uh oh!
There was an error while loading. Please reload this page.
Mean - #580
Conversation
The CI run on nightly seems to be failing for unrelated reasons (failing to install Rust itself). |
There was a problem hiding this comment.
The CI issue (due to rust-lang/rust#57488) is now fixed, so I re-ran CI.
I added a few comments. Additionally, if we add tests/numeric.rs (which is a good idea IMO), we should also move the relevant tests in tests/array.rs to it (e.g. sum_mean, sum_mean_empty, var_axis, std_axis, etc.).
Everything else looks good to me.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
LukeMathWalker
commented
Jan 14, 2019
All done - I have moved all the numeric tests I could spot in |
LukeMathWalker
commented
Jan 22, 2019
I am happy to do the changes to |
I'm not quite sure why I waited to merge this. (Maybe I was waiting on #577?) Anyway, let's go ahead and merge it. Thanks for your work on this @LukeMathWalker! Edit: I've rearranged the commit history to keep some commits separate but combine several small ones. |
Upstream
meanfromndarray-statstondarray.Breaking change on
mean_axis: it returnsOption<Array<A, D:Smaller>>now.