Skip to content

Add invmod API to Integer trait - #36

Closed
unseddd wants to merge 2 commits into
rust-num:masterfrom
unseddd:invmod
Closed

Add invmod API to Integer trait#36
unseddd wants to merge 2 commits into
rust-num:masterfrom
unseddd:invmod

Conversation

@unseddd

Copy link
Copy Markdown

No description provided.

@cuvipercuviper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some unit tests, and testable doc-examples would be nice.

This also overlaps with #10 -- if @vks responds I would give preference to their PR for coming first.

Comment threadsrc/lib.rs Outdated
@unseddd

Copy link
Copy Markdown
Author

This will need some unit tests, and testable doc-examples would be nice.

No problem, can update with unit tests, and try my hand at some doc-examples :)

This also overlaps with #10 -- if @vks responds I would give preference to their PR for coming first.

Didn't mean to step on any toes. Will definitely close, and give preference to @vks over this PR. Just wasn't sure if #10 was still relevant, since similar code exists in num-integer already (what's used by this PR).

@unseddd

Copy link
Copy Markdown
Author

@cuviper I added the requested changes, let me know what you think. Will squash the fixup, if you approve.

@vks

vks commented Jan 18, 2021 via email

Copy link
Copy Markdown
Contributor

@unseddd

Copy link
Copy Markdown
Author

Closing in favor of an updated #10

@unsedddunseddd closed this Jan 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@unseddd@vks@cuviper