Uh oh!
There was an error while loading. Please reload this page.
Make AllocRef implementation optional behind new alloc_ref feature - #27
Merged
Conversation
phil-oppforce-pushed
the
optional-alloc-ref
branch
from
March 6, 2020 10:35
9554055 to
4a0f8ddComparephil-opp
commented
Mar 6, 2020
MemberAuthor
Released together with #25 as v0.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AllocReftrait repeatedly changed and caused breakage recently (see #24 and #19). For this reason, I think it's better to make this feature optional so that users that only need theLockedHeaptype don't experience possible future breaking changes of theAllocReftrait.cc #25