Skip to content

Updating guide for Rand 0.8 - #28

Merged
dhardy merged 14 commits into
rust-random:masterfrom
vks:update-0.8
Dec 18, 2020
Merged

Updating guide for Rand 0.8#28
dhardy merged 14 commits into
rust-random:masterfrom
vks:update-0.8

Conversation

@vks

@vksvks commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

This is a first draft. It could be improved by adding external links (to num_traits and std).

dhardy
dhardy reviewed Sep 1, 2020
View reviewed changes

@dhardydhardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Of course, we're not done yet with 0.8 so should probably wait off merging.

Several comments refer to rand_distr changes, so I suppose we should mention the version numbers for that.

Comment threadsrc/update-0.8.md Outdated
Comment threadsrc/update-0.8.md Outdated
Comment threadsrc/update-0.8.md Outdated
Comment threadsrc/update-0.8.md Outdated
@dhardydhardy mentioned this pull request Sep 1, 2020
Closed
19 tasks
dhardy
dhardy approved these changes Sep 1, 2020
View reviewed changes

@dhardydhardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vks

vks commented Sep 15, 2020

Copy link
Copy Markdown
ContributorAuthor

I added comments about the new SmallRng algorithm and the getrandom update. I think this makes the guide complete for the Rand 0.8 release?

dhardy
dhardy reviewed Oct 19, 2020
View reviewed changes
Comment threadsrc/update-0.8.md Outdated
@dhardydhardy mentioned this pull request Dec 14, 2020
Merged
2 tasks
vks
vks commented Dec 15, 2020
View reviewed changes
Comment threadsrc/update-0.8.md Outdated
@dhardy

dhardy commented Dec 16, 2020

Copy link
Copy Markdown
Member

Can we mention rust-random/getrandom#178 and rust-random/getrandom#177? They aren't merged yet but whether or not v0.2.1 is out before rand v0.8, we should mention it here.

@dhardy

dhardy commented Dec 18, 2020

Copy link
Copy Markdown
Member

I'll merge now; we can make a new PR for any fixes.

@dhardy
dhardy merged commit 49a77a8 into rust-random:masterDec 18, 2020
@vks
vks deleted the update-0.8 branch December 18, 2020 18:38
@dhardydhardy mentioned this pull request Dec 18, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhardydhardydhardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vks@dhardy