Uh oh!
There was an error while loading. Please reload this page.
wasm32: Unify error codes and implementations - #146
Merged
Conversation
josephlr
commented
May 23, 2020
MemberAuthor
@dhardy I fixed the CI issue, this is ready for review. |
dhardy
commented
May 25, 2020
Member
Right now, while our implementations for stdweb and wasm-bindgen use similar APIs, they do not use similar implementations. This change: - Switches to using the same error codes for both implementations - Uses error codes that detail exactly what API is missing - Cleans up the implemetnations to make them much more readable - Consitantly use thread_local in both implementations This makes issues easier to debug and the code easier to understand. Signed-off-by: Joe Richey <joerichey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, while our implementations for stdweb and wasm-bindgen use
similar APIs, they do not use similar implementations. This change:
This makes issues easier to debug and the code easier to understand.
Signed-off-by: Joe Richey joerichey@google.com