Skip to content

Migrate CI to GitHub Actions - #180

Merged
newpavlov merged 2 commits into
masterfrom
ga_ci
Dec 14, 2020
Merged

Migrate CI to GitHub Actions#180
newpavlov merged 2 commits into
masterfrom
ga_ci

Conversation

@newpavlov

@newpavlovnewpavlov commented Dec 14, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Closes#174

Converts most existing tests except related to WASM targets.

@josephlr

josephlr commented Dec 14, 2020

Copy link
Copy Markdown
Member

@newpavlov Do you know why AppVeyor Is still running? Is there some way to turn it off?

@newpavlov

newpavlov commented Dec 14, 2020

Copy link
Copy Markdown
MemberAuthor

I am not sure. Probably because we still have its config in the master branch. Hopefully it will be solved after merge.

@dhardy

dhardy commented Dec 14, 2020

Copy link
Copy Markdown
Member

Yup, I can turn it off: (1) there's a webhook still registered and (2) AppVeyor was set up through my account. I'll clear it for you.

josephlr
josephlr approved these changes Dec 14, 2020
View reviewed changes

@josephlrjosephlr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I just have a few nits/questions

Comment thread.github/workflows/tests.yml Outdated
Comment thread.github/workflows/tests.yml
with:
profile: minimal
target: ${{ matrix.target }}
toolchain: nightly

@josephlrjosephlrDec 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the stable toolchain for these targets?

@newpavlovnewpavlovDec 14, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis config was using nightly, so I haven't changed it. I can try stable instead.

@newpavlovnewpavlovDec 14, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, I think it's worth to keep it nightly to allow early compiler bug detection if there will be any affecting us. I also will enable the cron job option to run CI periodically.

Comment thread.github/workflows/tests.yml
Comment thread.github/workflows/tests.yml Outdated
Comment thread.github/workflows/tests.yml
@newpavlov
newpavlov merged commit 6f11660 into masterDec 14, 2020
@newpavlov
newpavlov deleted the ga_ci branch December 14, 2020 21:50
@newpavlovnewpavlov mentioned this pull request Dec 14, 2020
Closed
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
@newpavlov
Migrate CI to GitHub Actions (rust-random#180)
3cb6893
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephlrjosephlrjosephlr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions?

3 participants

@newpavlov@josephlr@dhardy