Skip to content

Add fixes for Caching and rustc-dep-of-std feature - #198

Merged
josephlr merged 2 commits into
masterfrom
hermit
Jan 17, 2021
Merged

Add fixes for Caching and rustc-dep-of-std feature#198
josephlr merged 2 commits into
masterfrom
hermit

Conversation

@josephlr

@josephlrjosephlr commented Jan 14, 2021

Copy link
Copy Markdown
Member

We now cache the Cargo index (among other things) in our CI. This prevents some spurious test failures on Windows.

Also, Properly forward rustc-dep-of-std feature

@josephlr
josephlrforce-pushed the hermit branch 2 times, most recently from 9e6df8d to eeadc3bCompareJanuary 14, 2021 10:57
@newpavlov

Copy link
Copy Markdown
Member

IIRC on aarch64 Hermit simply always returns an error, did this situation change? In other words, any use of HashMap with such code would result in a panic, so the existing exception in the std integration PR looks like a better choice for now. Personally, I would prefer for hermit-os/kernel#143 to be solved first and for getrandom to use the new API.

The CI changes are probably better done in a separate PR.

@newpavlov

Copy link
Copy Markdown
Member

I like all changes, except the Hermit addition. :) How about removing the Hermit part for now, renaming this PR, and opening a tracking issue for the Hermit part?

@stlankes
Any ETA on adding a Linux-like syscall to Hermit as described in the linked issue?

Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlrjosephlr changed the title Add hermit supportAdd fixes for Caching and rustc-dep-of-std featureJan 17, 2021
@josephlr

Copy link
Copy Markdown
MemberAuthor

I like all changes, except the Hermit addition. :) How about removing the Hermit part for now, renaming this PR, and opening a tracking issue for the Hermit part?

Done. This PR now just contains the caching and rustc-dep-of-std fixes.

@josephlr

Copy link
Copy Markdown
MemberAuthor

#199 is now open to track all hermit <-> getrandom issues. Further discussion should continue there.

@josephlrjosephlr mentioned this pull request Jan 17, 2021
6 tasks
@stlankes

Copy link
Copy Markdown

A small comment to the ARM port, it comes, but the current version isn't stable. It takes some time.

@josephlr
josephlr merged commit 9a48bfa into masterJan 17, 2021
@josephlr
josephlr deleted the hermit branch January 17, 2021 20:32
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
Add fixes for Caching and rustc-dep-of-std feature
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@josephlr@newpavlov@stlankes