Uh oh!
There was an error while loading. Please reload this page.
Use getentropy on Emscripten - #307
Merged
Merged
Conversation
josephlrforce-pushed
the
emscripten
branch
4 times, most recently
from
October 23, 2022 05:58
e889c6d to
731ccc7Comparejosephlr
marked this pull request as ready for review
October 23, 2022 06:06
newpavlov
approved these changes
Oct 23, 2022
newpavlov
left a comment
Member
There was a problem hiding this comment.
Maybe it's worth to submit a patch which adds getentropy to libc? It looks like a small enough change for them to accept. But for now, I am fine with the manual declaration.
Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
commented
Oct 23, 2022
MemberAuthor
Sounds reasonable. I'm working on a few patches to send their way to make things easier on us w.r.t. declaring our own bindings. |
Merged
kleisauke
commented
May 20, 2023
FWIW, |
takumi-earth pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
Signed-off-by: Joe Richey <joerichey@google.com> Signed-off-by: Joe Richey <joerichey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#275, note that
libc::getentropyisn't in thelibccrate yet, so we have to manually declare the bindings.The last version of the EMSDK that didn't have support for this was 2.0.4 released over two years ago, so I don't think we have to worry about users using a super old SDK version, especially considering this is an less-used target.
Signed-off-by: Joe Richey joerichey@google.com