Do not use open64 by kraj · Pull Request #326 · rust-random/getrandom

kraj · 2022-12-29T05:51:24Z

glibc is providing open64 and other lfs64 functions but musl aliases them to normal equivalents since off_t is always 64-bit on musl, therefore check for target env along when target OS is linux before using open64, this is more available. Latest Musl has made these namespace changes [1]

[1] https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4

Signed-off-by: Khem Raj raj.khem@gmail.com

briansmith · 2022-12-30T00:46:43Z

Why do we ever need to use open64 in the first place? Since we never seek it seems like we should just avoid the conditional logic.

kraj · 2022-12-30T02:32:11Z

Why do we ever need to use open64 in the first place? Since we never seek it seems like we should just avoid the conditional logic.

I am fine by using open, I was trying to fix just musl case, but if we think its better to use just open I can update the patch

newpavlov · 2022-12-30T10:34:11Z

Why do we ever need to use open64 in the first place?

It's likely we have inherited it from std, but I agree that we probably do not need it. If @josephlr agrees, we should simply use open.

briansmith · 2023-01-02T21:47:49Z

What does libstd do for musl targets?

kraj · 2023-01-03T02:31:30Z

What does libstd do for musl targets?

The change to drop/deprecate LFS64 functions in musl is recent and has not yet made it to a GA release.
I will be fixing it in libstd-rs as well see rust-lang/rust#106246

josephlr · 2023-01-04T03:33:32Z

Why do we ever need to use open64 in the first place?
It's likely we have inherited it from std, but I agree that we probably do not need it. If @josephlr agrees, we should simply use open.

Looking through the various documentation, the only difference (if any) is the presence of O_LARGEFILE. That flag isn't relevant to us, as we are only opening a device (not a real file), so we never care about overflowing off_t.

Let's change this patch to just unconditionally use open.

josephlr · 2023-01-04T08:45:28Z

If you rebase this PR onto the latest master, the tests should be passing.

kraj · 2023-01-06T03:44:55Z

Why do we ever need to use open64 in the first place?
It's likely we have inherited it from std, but I agree that we probably do not need it. If @josephlr agrees, we should simply use open.
Looking through the various documentation, the only difference (if any) is the presence of O_LARGEFILE. That flag isn't relevant to us, as we are only opening a device (not a real file), so we never care about overflowing off_t.
Let's change this patch to just unconditionally use open.

done

kraj · 2023-01-06T03:45:18Z

If you rebase this PR onto the latest master, the tests should be passing.

cool. Uploaded a new version of PR. Lets see

glibc is providing open64 and other lfs64 functions but musl aliases them to normal equivalents since off_t is always 64-bit on musl, therefore check for target env along when target OS is linux before using open64, this is more available. Latest Musl has made these namespace changes [1] There is no need for using LFS64 open explicitly as we are only using it for opening device files and not real files [1] https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4 Signed-off-by: Khem Raj <raj.khem@gmail.com>

This fixes the build with musl-1.2.4, for those that are still experiencing issues these steps should resolve them: 1. Downgrade to musl-1.2.3 2. Rebuild dev-lang/rust with these patches 3. Upgrade to musl-1.2.4 again 4. Rebuild rust with USE=system-bootstrap At this point USE=system-boostrap will be required with >= musl-1.2.4 until uptream merges these patches and updates their boostrap. This was tested with musl-1.2.3, musl-1.2.4 and glibc-2.37-r3. Closes: https://bugs.gentoo.org/903607 Upstream-PR: rust-lang/rust#106246 Upstream-Issue: rust-lang/libc#2934 Upstream-PR: rust-lang/libc#2935 Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

This fixes the build with musl-1.2.4, for those that are still experiencing issues these steps should resolve them: 1. Downgrade to musl-1.2.3 2. Rebuild dev-lang/rust with these patches 3. Upgrade to musl-1.2.4 again 4. Rebuild rust with USE=system-bootstrap At this point USE=system-boostrap will be required with >= musl-1.2.4 until uptream merges these patches and updates their boostrap. This was tested with musl-1.2.3, musl-1.2.4 and glibc-2.37-r3. Closes: https://bugs.gentoo.org/903607 Upstream-PR: rust-lang/rust#106246 Upstream-Issue: rust-lang/libc#2934 Upstream-PR: rust-lang/libc#2935 Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

This fixes the build with musl-1.2.4, for those that are still experiencing issues these steps should resolve them: 1. Downgrade to musl-1.2.3 2. Rebuild dev-lang/rust with these patches 3. Upgrade to musl-1.2.4 again 4. Rebuild rust with USE=system-bootstrap This was tested with musl-1.2.3, musl-1.2.4 and glibc-2.37-r3. Closes: https://bugs.gentoo.org/903607 Upstream-PR: rust-lang/rust#106246 Upstream-Issue: rust-lang/libc#2934 Upstream-PR: rust-lang/libc#2935 Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

This fixes the build with musl-1.2.4, may need -system-bootstrap after updating musl. Closes: https://bugs.gentoo.org/903607 Upstream-PR: rust-lang/rust#106246 Upstream-Issue: rust-lang/libc#2934 Upstream-PR: rust-lang/libc#2935 Upstream-Commit: rust-lang/libc@1e8c55c Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

This version fixes compatibility with musl libc (rust-random/getrandom#326).

This fixes the build with musl-1.2.4, may need -system-bootstrap after updating musl. Closes: https://bugs.gentoo.org/903607 Upstream-PR: rust-lang/rust#106246 Upstream-Issue: rust-lang/libc#2934 Upstream-PR: rust-lang/libc#2935 Upstream-Commit: rust-lang/libc@1e8c55c Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

glibc is providing open64 and other lfs64 functions but musl aliases them to normal equivalents since off_t is always 64-bit on musl, therefore check for target env along when target OS is linux before using open64, this is more available. Latest Musl has made these namespace changes [1] There is no need for using LFS64 open explicitly as we are only using it for opening device files and not real files [1] https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4 Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>

kraj force-pushed the master branch from ad9a971 to 193ff54Compare January 6, 2023 03:44

newpavlov reviewed Jan 6, 2023
View reviewed changes

Comment threadsrc/util_libc.rs Outdated

kraj force-pushed the master branch from 193ff54 to 7c80ae7Compare January 6, 2023 08:22

newpavlov approved these changes Jan 6, 2023
View reviewed changes

newpavlov changed the title ~~Do not use open64 on linux with musl~~Do not use open64Jan 6, 2023

newpavlov merged commit 7f73e3c into rust-random:masterJan 6, 2023

newpavlov mentioned this pull request Apr 2, 2023
Release v0.2.9 #354
Merged

orbea mentioned this pull request May 28, 2023
dev-lang/rust: fix the build with musl-1.2.4 gentoo/gentoo#31205
Closed

orbea added a commit to orbea/gentoo that referenced this pull request Jun 5, 2023
www-client/firefox: fix the build with musl-1.2.4
76b74b7
Upstream-PR: rust-random/getrandom#326 Upstream-Commit: rust-random/getrandom@7f73e3c Signed-off-by: orbea <orbea@riseup.net>

orbea mentioned this pull request Jun 5, 2023
www-client/firefox: fix the build with musl-1.2.4 gentoo/gentoo#31310
Closed

link2xt mentioned this pull request Jun 6, 2023
Core 1.116.0 does not compile with musl chatmail/core#4457
Closed

nekopsykose mentioned this pull request Jul 20, 2023
use non-lfs64 api outside of glibc mozilla/audio_thread_priority#16
Closed

Cellesti mentioned this pull request Jul 23, 2023
Confirmation on license & two crate updates squidowl/halloy#174
Closed

jirutka added a commit to jirutka/deno that referenced this pull request Jul 23, 2023
chore(deps): bump getrandom to 0.2.10
175bb7c
This version fixes compatibility with musl libc (rust-random/getrandom#326).

jirutka mentioned this pull request Jul 23, 2023
chore(deps): bump getrandom to 0.2.10 denoland/deno#19914
Merged

bartlomieju pushed a commit to denoland/deno that referenced this pull request Jul 23, 2023
chore(deps): bump getrandom to 0.2.10 (#19914)
4ef080c
This version fixes compatibility with musl libc (rust-random/getrandom#326).

mmastrac pushed a commit to denoland/deno that referenced this pull request Jul 26, 2023
chore(deps): bump getrandom to 0.2.10 (#19914)
c72e549
This version fixes compatibility with musl libc (rust-random/getrandom#326).

svmhdvn mentioned this pull request Oct 8, 2023
Update getrandom crate to fix musl open64 link error azymohliad/watchmate#35
Merged

bjorn3 mentioned this pull request Jan 12, 2024
Linking error on Rust 1.75.0 x86_64-unknown-linux-musl toolchain (and in aarch64) rust-lang/rust#119883
Closed

misanthropos mentioned this pull request Apr 5, 2024
ja2-0.21.0 fails to be built when linking against musl libc ja2-stracciatella/ja2-stracciatella#1968
Closed

Navigation Menu

Uh oh!

Do not use open64 - #326

Do not use open64#326
newpavlov merged 1 commit into
rust-random:masterfrom
kraj:master

kraj commented Dec 29, 2022

Uh oh!

briansmith commented Dec 30, 2022

Uh oh!

kraj commented Dec 30, 2022

Uh oh!

newpavlov commented Dec 30, 2022

Uh oh!

briansmith commented Jan 2, 2023

Uh oh!

kraj commented Jan 3, 2023

Uh oh!

josephlr commented Jan 4, 2023

Uh oh!

josephlr commented Jan 4, 2023

Uh oh!

kraj commented Jan 6, 2023

Uh oh!

kraj commented Jan 6, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kraj commented Dec 29, 2022

Uh oh!

briansmith commented Dec 30, 2022

Uh oh!

kraj commented Dec 30, 2022

Uh oh!

newpavlov commented Dec 30, 2022

Uh oh!

briansmith commented Jan 2, 2023

Uh oh!

kraj commented Jan 3, 2023

Uh oh!

josephlr commented Jan 4, 2023

Uh oh!

josephlr commented Jan 4, 2023

Uh oh!

kraj commented Jan 6, 2023

Uh oh!

kraj commented Jan 6, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants