Skip to content

Test fallback file implementation on Linux/Android - #475

Closed
josephlr wants to merge 4 commits into
masterfrom
test_fallback
Closed

Test fallback file implementation on Linux/Android#475
josephlr wants to merge 4 commits into
masterfrom
test_fallback

Conversation

@josephlr

Copy link
Copy Markdown
Member

Fixes#289 for Linux. Depends on #471

Now when running cargo test on Linux, we see additional tests for the file-based implementation:

running 11 tests
test error::tests::test_size ... ok
test imp::fallback::fill_large ... ok
test imp::fallback::fill_zero ... ok
test tests::fill_large ... ok
test tests::fill_zero ... ok
test imp::fallback::multithreading ... ok
test tests::multithreading ... ok
test imp::fallback::fill_small ... ok
test tests::fill_small ... ok
test imp::fallback::fill_huge ... ok
test tests::fill_huge ... ok

@josephlrjosephlr mentioned this pull request Jun 12, 2024
@josephlr
josephlrforce-pushed the test_fallback branch 4 times, most recently from 92cc8f6 to 37fd41bCompareJune 19, 2024 10:27
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr

josephlr commented Jun 20, 2024

Copy link
Copy Markdown
MemberAuthor

Closing to keep conversation in #471

Nevermind, this change should probably be review separately.

Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
@newpavlov

Copy link
Copy Markdown
Member

Closing in favor of #506.

@newpavlov
newpavlov deleted the test_fallback branch October 11, 2024 00:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For platforms that implement runtime fallback logic, all paths should be tested

2 participants

@josephlr@newpavlov